emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [babel] Export problem (Wrong type argument: consp, nil)
Date: Thu, 15 Sep 2011 09:10:47 -0600	[thread overview]
Message-ID: <87wrd9hkfv.fsf@gmail.com> (raw)
In-Reply-To: 80y5xrld4x.fsf@somewhere.org

>
> Question: Would it be possible to add the src-name in the error
> message?

Unfortunately the code block name is not known to the function (namely
`org-babel-merge-params') which throws errors when variables are not
assigned default values.  In fact this function may be called when there
are no code blocks present.  I think that this is why you ran into
problems trying to thread the code block info down into this error
message.

Another option may be to check when a code block is initially parsed to
ensure that all variables are assigned default parameters.  If the
checking is done initially then the code block name and position will be
known and could be included into the error message.  There exists a
function for checking code blocks (namely `org-babel-check-src-block'),
I've added a TODO to this function to add a check that all variables are
initialized.

>
> * Test
>
> #+begin_src emacs-lisp
> (ert-deftest test-org-babel/no-defaut-value-for-var ()
>   "Test that the absence of a default value for a variable does throw a proper
>   error."
>   (org-test-at-id "f2df5ba6-75fa-4e6b-8441-65ed84963627"
>     (org-babel-next-src-block)
>     (should-error (org-babel-execute-src-block))
>     :type 'error))
> #+end_src
>
> Though, I have 2 questions:
>
> - How can I differentiate between the clean error (with a message) and the one
>   which wasn't correctly trapped?  Based on the first line of a backtrace
>   (string comparison) or on the type of the error?  In the latter case, how
>   can I know what's the type of the current error thrown, and the one of the
>   error before your fix?
>

I believe Martyn answered this question

>
> - I wonder why we need twice the =org-babel-next-src-block= call, and
>   not only once in the =should-error= form.
>

I only see a single call to org-babel-next-src-block in the above test.

Thanks for working on this test, I look forward to adding it once it is
completed.

Cheers -- Eric

>
> Thanks.
>
> Best regards,
>   Seb

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2011-09-15 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 15:15 [babel] Export problem (Wrong type argument: consp, nil) Sebastien Vauban
2011-09-08 17:33 ` Eric Schulte
2011-09-14  8:52   ` Sebastien Vauban
2011-09-14 11:44     ` Martyn Jago
2011-09-15 15:10     ` Eric Schulte [this message]
2011-09-16  9:57       ` Sebastien Vauban
2011-09-16 10:12       ` Sebastien Vauban
2011-09-16 15:25         ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrd9hkfv.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).