From: stardiviner <numbchild@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org, Ihor Radchenko <yantar92@gmail.com>
Subject: Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines
Date: Wed, 15 Apr 2020 09:13:18 +0800 [thread overview]
Message-ID: <87o8rteekx.fsf@gmail.com> (raw)
In-Reply-To: <877dyi1b22.fsf@nicolasgoaziou.fr>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I agree. As I described in my given example "org-contacts", which include person
>> info in properties drawer. That's why I want to expand when I press "Tab" on
>> expanding headline. If I see a contact's info with "C-u C-u C-u Tab" is not
>> convenient.
>
> You can rebind it.
>
>> Is it possible to change "org-cycle-hide-drawers" to "org-cycle-toggle-drawers".
>> Make it more extendable. Because that function only changed one argument of
>> "org-flag-drawer". If so some user like me will be easy to toggle hide/show
>> drawers. (Of course, I don't want to add redundant code in my Emacs init.) If
>> this is fine, I will re-edit my patch. Remove defcustom option, and hook on
>> cycle. Only keep changes in "org-cycle-hide-drawers".
>
> I think something is wrong with `org-cycle-hide-drawers' at the moment.
> This function was initially meant to be added to `org-cycle-hook' to
> re-hide drawers. It should only re-hide properties drawers. In any case,
> it is not needed to expand this function, it should be trimmed down to
> only take care of property drawers.
>
> What is needed, though, it a tooling similar to block visibility
> functions, i.e., `org-hide-block-toggle', `org-hide-block-hall', and,
> maybe, `org-hide-block-toggle-maybe'. Regular drawers should get the
> same treatment as blocks.
>
> If you look at `org-cycle' code, there is a comment
>
> ;; Drawers: delegate to `org-flag-drawer'.
>
> This part should be extracted into a new function.
This sounds reasonable. (I deleted my patch on my local fork, I think your solution is better.)
- --
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----
iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6WX64UHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMKJggAzKm3lD0NTcG4eak7khuzw5bbt9W6
MNi8kkK61LWaPfW+BgCGxJz+RAYnKnPca7JDZ15xEwcVc1/UIFZ4bFTmeH25/yjp
49KsTVR4E8mgueAgm+Js1uNTj2GUXhvBpiu8RjPe6578GHzopLUbBgvTgPtZVswa
A9Mr3ecu3lFMja3KfjoB73w3sa6UncwQ3zqhiV6zqVFAcrO02YYfgLAFhmYjKQ5h
b5hkdxliZsL6H6kgLG7TQFwu1S1vpgGZNaZvz6sS9h3PO3UwglbCGxWo8EFsYHiz
+YFJMw3FcGxdXygp9l+ypG1Zhpwr7arZE8Zuq4ypduxmjWkUyOG7O6dbdA==
=haRH
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2020-04-15 1:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 8:43 [PATCH] Show hidden drawers when org-cycle on headlines stardiviner
2020-04-11 16:05 ` Nicolas Goaziou
2020-04-13 3:29 ` stardiviner
2020-04-13 8:06 ` Nicolas Goaziou
2020-04-13 16:28 ` stardiviner
2020-04-13 9:12 ` Ihor Radchenko
2020-04-13 16:31 ` [SOLVED] " stardiviner
2020-04-13 16:58 ` Ihor Radchenko
2020-04-13 20:00 ` Nicolas Goaziou
2020-04-13 23:19 ` Tim Cross
2020-04-14 3:18 ` Ihor Radchenko
2020-04-14 12:58 ` Nicolas Goaziou
2020-04-14 13:57 ` Ihor Radchenko
2020-04-14 5:21 ` stardiviner
2020-04-14 12:55 ` Nicolas Goaziou
2020-04-15 1:13 ` stardiviner [this message]
2020-04-18 17:48 ` Nicolas Goaziou
2020-04-19 9:10 ` stardiviner
2020-04-19 10:31 ` Nicolas Goaziou
2020-04-19 11:31 ` stardiviner
2020-04-13 20:52 ` Samuel Wales
2020-04-15 1:26 ` [SOLUTION] " stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8rteekx.fsf@gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).