* obsolete function in org-bibtex.el and merges from emacs
@ 2013-02-14 20:26 Aaron Ecay
2013-02-15 22:36 ` Bastien
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Ecay @ 2013-02-14 20:26 UTC (permalink / raw)
To: Org-mode
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Hello,
org-bibtex.el contains a reference to longlines-mode, which is obsolete
in emacs trunk since Dec. 4. When the function was made obsolete, the
version of org distributed with emacs was changed to use
visual-line-mode (the successor to longlines-mode).
But it seems that this change hasn’t made it to the orgmode git repo yet
– either on the master or maint branches. Is that an expected result?
In case it’s useful, I’ve attached a patch to make this change.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-bibtex-use-visual-line-mode-instead-of-longlines.patch --]
[-- Type: text/x-patch, Size: 1412 bytes --]
From ca6aa9d062b72877d6b6cece518786b6c6de6c95 Mon Sep 17 00:00:00 2001
From: Aaron Ecay <aaronecay@gmail.com>
Date: Thu, 14 Feb 2013 15:22:10 -0500
Subject: [PATCH] org-bibtex: use visual-line-mode instead of longlines-mode
The latter function has been removed from emacs as of version 24.
TINYCHANGE
---
lisp/org-bibtex.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el
index f50ecd3..65de4fb 100644
--- a/lisp/org-bibtex.el
+++ b/lisp/org-bibtex.el
@@ -120,7 +120,6 @@
(declare-function bibtex-generate-autokey "bibtex" ())
(declare-function bibtex-parse-entry "bibtex" (&optional content))
(declare-function bibtex-url "bibtex" (&optional pos no-browse))
-(declare-function longlines-mode "longlines" (&optional arg))
(declare-function org-babel-trim "ob" (string &optional regexp))
\f
@@ -381,7 +380,7 @@ This variable is relevant only if `org-bibtex-export-tags-as-keywords' is t."
(buf-name (format "*Bibtex Help %s*" name)))
(with-output-to-temp-buffer buf-name
(princ (cdr (assoc field org-bibtex-fields))))
- (with-current-buffer buf-name (longlines-mode t))
+ (with-current-buffer buf-name (visual-line-mode 1))
(org-fit-window-to-buffer (get-buffer-window buf-name))
((lambda (result) (when (> (length result) 0) result))
(read-from-minibuffer (format "%s: " name))))))
--
1.8.1.3
[-- Attachment #3: Type: text/plain, Size: 25 bytes --]
Thanks,
--
Aaron Ecay
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: obsolete function in org-bibtex.el and merges from emacs
2013-02-14 20:26 obsolete function in org-bibtex.el and merges from emacs Aaron Ecay
@ 2013-02-15 22:36 ` Bastien
0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2013-02-15 22:36 UTC (permalink / raw)
To: Aaron Ecay; +Cc: Org-mode
Hi Aaron,
Aaron Ecay <aaronecay@gmail.com> writes:
> org-bibtex.el contains a reference to longlines-mode, which is obsolete
> in emacs trunk since Dec. 4. When the function was made obsolete, the
> version of org distributed with emacs was changed to use
> visual-line-mode (the successor to longlines-mode).
>
> But it seems that this change hasn’t made it to the orgmode git repo yet
> – either on the master or maint branches. Is that an expected result?
>
> In case it’s useful, I’ve attached a patch to make this change.
Applied, thanks!
--
Bastien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-15 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-14 20:26 obsolete function in org-bibtex.el and merges from emacs Aaron Ecay
2013-02-15 22:36 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).