From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: obsolete function in org-bibtex.el and merges from emacs Date: Thu, 14 Feb 2013 15:26:18 -0500 Message-ID: <87k3qak5g5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U65Nv-00040W-HT for emacs-orgmode@gnu.org; Thu, 14 Feb 2013 15:26:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U65Nt-000118-NG for emacs-orgmode@gnu.org; Thu, 14 Feb 2013 15:26:23 -0500 Received: from mail-ve0-f174.google.com ([209.85.128.174]:49102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U65Nt-000110-Hz for emacs-orgmode@gnu.org; Thu, 14 Feb 2013 15:26:21 -0500 Received: by mail-ve0-f174.google.com with SMTP id pb11so2441797veb.19 for ; Thu, 14 Feb 2013 12:26:21 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org-mode --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, org-bibtex.el contains a reference to longlines-mode, which is obsolete in emacs trunk since Dec. 4. When the function was made obsolete, the version of org distributed with emacs was changed to use visual-line-mode (the successor to longlines-mode). But it seems that this change hasn=E2=80=99t made it to the orgmode git rep= o yet =E2=80=93 either on the master or maint branches. Is that an expected resu= lt? In case it=E2=80=99s useful, I=E2=80=99ve attached a patch to make this cha= nge. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-bibtex-use-visual-line-mode-instead-of-longlines.patch >From ca6aa9d062b72877d6b6cece518786b6c6de6c95 Mon Sep 17 00:00:00 2001 From: Aaron Ecay Date: Thu, 14 Feb 2013 15:22:10 -0500 Subject: [PATCH] org-bibtex: use visual-line-mode instead of longlines-mode The latter function has been removed from emacs as of version 24. TINYCHANGE --- lisp/org-bibtex.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el index f50ecd3..65de4fb 100644 --- a/lisp/org-bibtex.el +++ b/lisp/org-bibtex.el @@ -120,7 +120,6 @@ (declare-function bibtex-generate-autokey "bibtex" ()) (declare-function bibtex-parse-entry "bibtex" (&optional content)) (declare-function bibtex-url "bibtex" (&optional pos no-browse)) -(declare-function longlines-mode "longlines" (&optional arg)) (declare-function org-babel-trim "ob" (string &optional regexp)) @@ -381,7 +380,7 @@ This variable is relevant only if `org-bibtex-export-tags-as-keywords' is t." (buf-name (format "*Bibtex Help %s*" name))) (with-output-to-temp-buffer buf-name (princ (cdr (assoc field org-bibtex-fields)))) - (with-current-buffer buf-name (longlines-mode t)) + (with-current-buffer buf-name (visual-line-mode 1)) (org-fit-window-to-buffer (get-buffer-window buf-name)) ((lambda (result) (when (> (length result) 0) result)) (read-from-minibuffer (format "%s: " name)))))) -- 1.8.1.3 --=-=-= Content-Type: text/plain Thanks, -- Aaron Ecay --=-=-=--