emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Warning with latest git pull
Date: Mon, 25 Feb 2013 11:50:03 +0100	[thread overview]
Message-ID: <87mwusmzvo.fsf@bzg.ath.cx> (raw)
In-Reply-To: <8738wm10pr.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 24 Feb 2013 11:10:40 +0100")

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> We shouldn't define things that don't have an org prefix.

Fair enough.

(Note that `with-buffer-modified-unmodified', from which
org-unmodified was heavily copied, lives in bookmark.el.  Perhaps
Emacs should put it elsewhere.)

> I don't really see why we needed to replace org-unmodified in the
> first place, especially since with-silent-modifications does _more_
> than org-unmodified,

Especially *because* it does more.  In particular, it does set
`buffer-file-name' and `buffer-file-truename' to nil, which is 
a problem when preparing the agenda buffers.

> not less as your comment in org-macs would imply.

I fixed the comment, thanks.

> Here's a patch to restore org-unmodified in the sources, make it an
> alias to with-silent-modifications when possible and augment the
> replacement definition with a few things that with-silent-modifications
> does on top of what org-unmodified did.  We might even copy the whole
> macro definition from subr.el, but I think we're close enough with this.

Thanks -- I applied a different patch, using `org-with-silent-modifications'
as a compatibility macro for `with-silent-modifications'.

Best,

-- 
 Bastien

next prev parent reply	other threads:[~2013-02-25 10:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 18:18 Warning with latest git pull Thomas S. Dye
2013-02-21 21:12 ` Bastien
2013-02-23  9:22   ` Achim Gratz
2013-02-23 11:21     ` Bastien
2013-02-23 11:57       ` Achim Gratz
2013-02-23 13:00         ` Bastien
2013-02-23 13:37           ` Achim Gratz
2013-02-25  9:54             ` Bastien
2013-02-23 19:53           ` Achim Gratz
2013-02-24  9:29             ` Bastien
2013-02-24 10:10               ` Achim Gratz
2013-02-25 10:50                 ` Bastien [this message]
2013-02-25 17:27                   ` Achim Gratz
2013-02-26 13:53                     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwusmzvo.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).