From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Warning with latest git pull Date: Mon, 25 Feb 2013 11:50:03 +0100 Message-ID: <87mwusmzvo.fsf@bzg.ath.cx> References: <87a9qxl6bv.fsf@bzg.ath.cx> <87621jxu41.fsf@Rainer.invalid> <87r4k746o8.fsf@bzg.ath.cx> <87sj4nw8d6.fsf@Rainer.invalid> <87liaf422j.fsf@bzg.ath.cx> <87sj4mx0wb.fsf@Rainer.invalid> <87r4k6cb5u.fsf@bzg.ath.cx> <8738wm10pr.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9vdQ-00006u-8u for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:50:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9vdK-00066P-T5 for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:50:15 -0500 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:61428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9vdK-00065Z-Ms for emacs-orgmode@gnu.org; Mon, 25 Feb 2013 05:50:10 -0500 Received: by mail-wi0-f170.google.com with SMTP id hm11so4405657wib.3 for ; Mon, 25 Feb 2013 02:50:08 -0800 (PST) In-Reply-To: <8738wm10pr.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 24 Feb 2013 11:10:40 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > We shouldn't define things that don't have an org prefix. Fair enough. (Note that `with-buffer-modified-unmodified', from which org-unmodified was heavily copied, lives in bookmark.el. Perhaps Emacs should put it elsewhere.) > I don't really see why we needed to replace org-unmodified in the > first place, especially since with-silent-modifications does _more_ > than org-unmodified, Especially *because* it does more. In particular, it does set `buffer-file-name' and `buffer-file-truename' to nil, which is a problem when preparing the agenda buffers. > not less as your comment in org-macs would imply. I fixed the comment, thanks. > Here's a patch to restore org-unmodified in the sources, make it an > alias to with-silent-modifications when possible and augment the > replacement definition with a few things that with-silent-modifications > does on top of what org-unmodified did. We might even copy the whole > macro definition from subr.el, but I think we're close enough with this. Thanks -- I applied a different patch, using `org-with-silent-modifications' as a compatibility macro for `with-silent-modifications'. Best, -- Bastien