* Patch on org-agenda-cmp-user-defined not called
@ 2017-07-06 1:06 Li Zhuo
2017-07-06 16:53 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Li Zhuo @ 2017-07-06 1:06 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 11 bytes --]
--
lizhuo
[-- Attachment #1.2: Type: text/html, Size: 124 bytes --]
[-- Attachment #2: 0001-fix-org-agenda-cmp-user-defined-not-called-when-user.patch --]
[-- Type: text/x-patch, Size: 1104 bytes --]
From ed3ca2c1ea88b452fe3d324216740664de83a218 Mon Sep 17 00:00:00 2001
From: Vacker <fantanstic@gmail.com>
Date: Wed, 5 Jul 2017 19:38:01 +0800
Subject: [PATCH] fix `org-agenda-cmp-user-defined` not called when user has
defined it
---
lisp/org-agenda.el | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 652fada..3a0248e 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7007,10 +7007,9 @@ their type."
(alpha-down (if alpha-up (- alpha-up) nil))
(need-user-cmp (org-em 'user-defined-up 'user-defined-down ss))
user-defined-up user-defined-down)
- (if (and need-user-cmp org-agenda-cmp-user-defined
- (functionp org-agenda-cmp-user-defined))
+ (if (and need-user-cmp (functionp 'org-agenda-cmp-user-defined))
(setq user-defined-up
- (funcall org-agenda-cmp-user-defined a b)
+ (funcall 'org-agenda-cmp-user-defined a b)
user-defined-down (if user-defined-up (- user-defined-up) nil)))
(cdr (assoc
(eval (cons 'or org-agenda-sorting-strategy-selected))
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Patch on org-agenda-cmp-user-defined not called
2017-07-06 1:06 Patch on org-agenda-cmp-user-defined not called Li Zhuo
@ 2017-07-06 16:53 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-07-06 16:53 UTC (permalink / raw)
To: Li Zhuo; +Cc: emacs-orgmode
Hello,
Li Zhuo <fantanstic@gmail.com> writes:
> Subject: [PATCH] fix `org-agenda-cmp-user-defined` not called when user has
> defined it
>
> ---
> lisp/org-agenda.el | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 652fada..3a0248e 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7007,10 +7007,9 @@ their type."
> (alpha-down (if alpha-up (- alpha-up) nil))
> (need-user-cmp (org-em 'user-defined-up 'user-defined-down ss))
> user-defined-up user-defined-down)
> - (if (and need-user-cmp org-agenda-cmp-user-defined
> - (functionp org-agenda-cmp-user-defined))
> + (if (and need-user-cmp (functionp 'org-agenda-cmp-user-defined))
> (setq user-defined-up
> - (funcall org-agenda-cmp-user-defined a b)
> + (funcall 'org-agenda-cmp-user-defined a b)
> user-defined-down (if user-defined-up (- user-defined-up) nil)))
> (cdr (assoc
> (eval (cons 'or org-agenda-sorting-strategy-selected))
Thank you.
However, I don't understand what your patch is fixing. Could you exhibit
the problem with a simple recipe?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-06 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 1:06 Patch on org-agenda-cmp-user-defined not called Li Zhuo
2017-07-06 16:53 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).