From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Patch on org-agenda-cmp-user-defined not called
Date: Thu, 06 Jul 2017 18:53:57 +0200
Message-ID: <87mv8h7bh6.fsf@nicolasgoaziou.fr>
References: <CA+viYURioQ2aTG=Ht-FAtyF+0SUioJBntAagLkkNhbQZH3NBDA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dTA2Y-0008VF-32
	for emacs-orgmode@gnu.org; Thu, 06 Jul 2017 12:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dTA2U-0000I1-6Q
	for emacs-orgmode@gnu.org; Thu, 06 Jul 2017 12:54:06 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:52895)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dTA2U-0000H3-0g
	for emacs-orgmode@gnu.org; Thu, 06 Jul 2017 12:54:02 -0400
In-Reply-To: <CA+viYURioQ2aTG=Ht-FAtyF+0SUioJBntAagLkkNhbQZH3NBDA@mail.gmail.com>
	(Li Zhuo's message of "Thu, 6 Jul 2017 09:06:57 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Li Zhuo <fantanstic@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Li Zhuo <fantanstic@gmail.com> writes:

> Subject: [PATCH] fix `org-agenda-cmp-user-defined` not called when user has
>  defined it
>
> ---
>  lisp/org-agenda.el | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 652fada..3a0248e 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7007,10 +7007,9 @@ their type."
>  	 (alpha-down      (if alpha-up (- alpha-up) nil))
>  	 (need-user-cmp   (org-em 'user-defined-up 'user-defined-down ss))
>  	 user-defined-up user-defined-down)
> -    (if (and need-user-cmp org-agenda-cmp-user-defined
> -	     (functionp org-agenda-cmp-user-defined))
> +    (if (and need-user-cmp (functionp 'org-agenda-cmp-user-defined))
>  	(setq user-defined-up
> -	      (funcall org-agenda-cmp-user-defined a b)
> +	      (funcall 'org-agenda-cmp-user-defined a b)
>  	      user-defined-down (if user-defined-up (- user-defined-up) nil)))
>      (cdr (assoc
>  	  (eval (cons 'or org-agenda-sorting-strategy-selected))

Thank you.

However, I don't understand what your patch is fixing. Could you exhibit
the problem with a simple recipe?

Regards,

-- 
Nicolas Goaziou