emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [9.5.2] [org-keys] [cursor keys with modifiers] ESC <left> missing?
@ 2022-02-05 16:28 R Primus
  2022-05-06 10:42 ` [PATCH] " Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: R Primus @ 2022-02-05 16:28 UTC (permalink / raw)
  To: emacs-orgmode

Sat  5 Feb 2022 16:03:31 GMT

Hi,

Ref: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/org-keys.el#n463

For `(org-defkey org-mode-map (kbd "ESC <left>") #'org-metaleft)`, just wondering if:

1. this was intentionally left out, and
2. if so, what is the reason?

This causes user `surprise` when switching from using emacs/org-mode in
the terminal to a GUI session.

-- 
-primus (Train yourself and be your own master.)
Find something to love in whatever you are doing - it's all about mindset.
"First, solve the problem.  Then, write the code." - John Johnson
"Narrowness of experience leads to narrowness of imagination." - Rob Pike
https://www.catb.org/esr/faqs/smart-questions.html
https://www.chiark.greenend.org.uk/~sgtatham/bugs.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Re: [9.5.2] [org-keys] [cursor keys with modifiers] ESC <left> missing?
  2022-02-05 16:28 [9.5.2] [org-keys] [cursor keys with modifiers] ESC <left> missing? R Primus
@ 2022-05-06 10:42 ` Ihor Radchenko
  2022-07-22 13:36   ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2022-05-06 10:42 UTC (permalink / raw)
  To: R Primus; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

R Primus <rprimus+org@gmail.com> writes:

> For `(org-defkey org-mode-map (kbd "ESC <left>") #'org-metaleft)`, just wondering if:
>
> 1. this was intentionally left out, and
> 2. if so, what is the reason?
>
> This causes user `surprise` when switching from using emacs/org-mode in
> the terminal to a GUI session.

I tied to dig into commit history and I do not see any justification why
ESC <left> could be omitted from default non-terminal bindings.

I agree that the current behaviour is inconsistent.

The fix is attached.

Best,
Ihor


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-keys-Bind-ESC-left-by-default.patch --]
[-- Type: text/x-patch, Size: 1212 bytes --]

From 7232400abe73c9d4ad667781146f1b5da14b64a4 Mon Sep 17 00:00:00 2001
Message-Id: <7232400abe73c9d4ad667781146f1b5da14b64a4.1651833603.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Fri, 6 May 2022 18:37:10 +0800
Subject: [PATCH] org-keys: Bind ESC <left> by default

* lisp/org-keys.el (org-mode-map): Bind `org-metaleft' to ESC <left>
by default, not just in terminals.  This completes the ESC <arrow>
binding group.  ESC <right>, <up>, and <down> are already bound and
missing ESC <left> can be confusing.

Reported in https://orgmode.org/list/Yf6lsTR3JSNSXRDX@x.local
---
 lisp/org-keys.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-keys.el b/lisp/org-keys.el
index 782ffa871..e96fa217b 100644
--- a/lisp/org-keys.el
+++ b/lisp/org-keys.el
@@ -462,6 +462,7 @@ (org-defkey org-mode-map (kbd "M-RET") #'org-meta-return)
 
 ;;;; Cursor keys with modifiers
 (org-defkey org-mode-map (kbd "M-<left>") #'org-metaleft)
+(org-defkey org-mode-map (kbd "ESC <left>") #'org-metaleft)
 (org-defkey org-mode-map (kbd "M-<right>") #'org-metaright)
 (org-defkey org-mode-map (kbd "ESC <right>") #'org-metaright)
 (org-defkey org-mode-map (kbd "M-<up>") #'org-metaup)
-- 
2.35.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Re: [9.5.2] [org-keys] [cursor keys with modifiers] ESC <left> missing?
  2022-05-06 10:42 ` [PATCH] " Ihor Radchenko
@ 2022-07-22 13:36   ` Ihor Radchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2022-07-22 13:36 UTC (permalink / raw)
  To: R Primus; +Cc: emacs-orgmode

Ihor Radchenko <yantar92@gmail.com> writes:

> The fix is attached.

Applied onto main via b6098500a.

Best,
Ihor


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-22 13:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 16:28 [9.5.2] [org-keys] [cursor keys with modifiers] ESC <left> missing? R Primus
2022-05-06 10:42 ` [PATCH] " Ihor Radchenko
2022-07-22 13:36   ` Ihor Radchenko

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).