From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4LkUH4f7dGLxnQAAbAwnHQ (envelope-from ) for ; Fri, 06 May 2022 12:42:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SJAsHof7dGLzYgAAG6o9tA (envelope-from ) for ; Fri, 06 May 2022 12:42:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0947228127 for ; Fri, 6 May 2022 12:42:14 +0200 (CEST) Received: from localhost ([::1]:59518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmvPZ-0001e3-4g for larch@yhetil.org; Fri, 06 May 2022 06:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmvP0-0001du-LF for emacs-orgmode@gnu.org; Fri, 06 May 2022 06:41:38 -0400 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]:33488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmvOy-00051W-Vr for emacs-orgmode@gnu.org; Fri, 06 May 2022 06:41:38 -0400 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-e656032735so6811500fac.0 for ; Fri, 06 May 2022 03:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=82jubpYovAwZbJgpOQ3ybJbxJ5BlZaU1pGBIoQYSUaQ=; b=l02Mb8ehtBVrCv6Ft2UIRYQSQKso7L3pNxGL+QlswX1qwNJG/+dUt/3h7E1CwI8BEI IDy3x5o69KFEl61+ppNsSSo1+6EFfqNSzFffFvq+/RPe/+jX1m7Ww/FrrEUXDMjmhXWj R1aetcUqCbUevmCoaOmD8Pw3WXL4TqOwYWe7NmuSJ/cCBStDOwuTupZdecYjvsKxmvze jY4bbGkhv3WvpKiQVpTj8LDaI0seHZQTQoxhmaeDP1ItZDotgNzlU0ReO3cZMVPLXuvr HdKAHrABkP0mGvRzaGi84W8ef1kwGuOBhL+8yaSaiV2NTweEMwh45nqXZWeqzkfIuUlN HKTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=82jubpYovAwZbJgpOQ3ybJbxJ5BlZaU1pGBIoQYSUaQ=; b=z4myiMtsr4P7ioZjwsLYkG4YU/4u43X03n2prTMANKIvnYlv2HTTv6+0lK4rJAIQFY NwcxwNN4lSi4WZmyXtOsAkA0zTGwBZ0DOEmA+8Y54b5c4g/8Jti4pVQMrG7DPJRmkHEg EnZ2O+hn1vp/riYZClWNMa1y4iMZ2Yup9ER2SfiV1hg6PyV9CWUQ72KZpkiO91zXsvbw SFvreIeYmdEISOuUcwdW9h3JwiV4Wh/XzhS4ggnkfZOYpc+v6v6D0bf4gAvgEqbsSqPq XwUjoWaO1+IepXJJumJTKvzvFwQC2eQ5vae/bRyXrgozPoA4lTVgw36Y8/kmg1Ke52SR 3jSA== X-Gm-Message-State: AOAM532Pfg+Fm5UqVZybKT/kk5WTjH5JMTCc7B9PgZHuSpuAXiv/+bwm B7vCxbi/yujlUKjqgKh+d/o= X-Google-Smtp-Source: ABdhPJw9Iw1BakV/ZzhFQJ+RMFguiv0+RkfSsR7iYjs4yyluL8r8jXW0Se1jYMb4+qZyL5OBo0eY6g== X-Received: by 2002:a05:6870:b62a:b0:dd:f3b0:96da with SMTP id cm42-20020a056870b62a00b000ddf3b096damr4036320oab.258.1651833695643; Fri, 06 May 2022 03:41:35 -0700 (PDT) Received: from localhost ([104.223.98.2]) by smtp.gmail.com with ESMTPSA id t6-20020a056870f20600b000e686d1388dsm1551595oao.39.2022.05.06.03.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 03:41:35 -0700 (PDT) From: Ihor Radchenko To: R Primus Cc: emacs-orgmode@gnu.org Subject: [PATCH] Re: [9.5.2] [org-keys] [cursor keys with modifiers] ESC missing? In-Reply-To: References: Date: Fri, 06 May 2022 18:42:18 +0800 Message-ID: <87mtfv6iyd.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=yantar92@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651833735; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=82jubpYovAwZbJgpOQ3ybJbxJ5BlZaU1pGBIoQYSUaQ=; b=PqZ1m0WEI6FwI/EZXluR5+D7260x6neXP8rnh0lI7gwF1SQ+wD202W93dPFok4Cw2gssvv L69x+PHy/Tlfaa7Q7/S6ZnFkHHi8hz/6tP6YE8R4KxBHau6P2oHZh//bQpeIsbEcYYqlys bnLKWYfL2nxCg4rgxo16E5bZlFs5Ok7nrAVYzOLh6FgGQ38dQ3yodVkxnpmIPTzSFnGY+Z mdUnj+LXROcQ7PgcEa4d4hy963GRKLcRtCQgY2A14N9FCgAB4HNRs1BXB2TjJp1E9AGtkZ z+w3oR1NKliYspEKkgi2ELGNXUlYLel5BKBEb9gAnFt4r+yrpOzPXOh2Qt96wQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651833735; a=rsa-sha256; cv=none; b=AtwwpuiiJHjBeee9zbhiC11FCWb+UiLQtuBr3lF5hT/00Nu+nmExBQ/c6GbBIHrfTsA7dk yTqdJOQI7qyoFbs1yRN3q5lP8DU5A9FF2QrVj1vsvtZt7gliD45Ay2q0+bO8qsc2zhZ0Bo mq3aK0ebJDPG0uwZb0bM4pZ5S+sEFSfMuH1gtllOYrVnQ+EeAMPOUkqbC0wfil4bt2b1sA Zg7mnI3iKkXxks6bXhZbMTa6LFp0EmKIYh32LWqemf1GSnS6lKeec1goLRD5cNNr1FlXA1 NxMDNUpXP9CmVe8+SW8vltmlqZ0ZgfA/O1yip3/mkQJqVi1Ji1vn4DIQjtdOag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l02Mb8eh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.30 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l02Mb8eh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0947228127 X-Spam-Score: -8.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: Wy6sfBsEL2jm --=-=-= Content-Type: text/plain R Primus writes: > For `(org-defkey org-mode-map (kbd "ESC ") #'org-metaleft)`, just wondering if: > > 1. this was intentionally left out, and > 2. if so, what is the reason? > > This causes user `surprise` when switching from using emacs/org-mode in > the terminal to a GUI session. I tied to dig into commit history and I do not see any justification why ESC could be omitted from default non-terminal bindings. I agree that the current behaviour is inconsistent. The fix is attached. Best, Ihor --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-keys-Bind-ESC-left-by-default.patch >From 7232400abe73c9d4ad667781146f1b5da14b64a4 Mon Sep 17 00:00:00 2001 Message-Id: <7232400abe73c9d4ad667781146f1b5da14b64a4.1651833603.git.yantar92@gmail.com> From: Ihor Radchenko Date: Fri, 6 May 2022 18:37:10 +0800 Subject: [PATCH] org-keys: Bind ESC by default * lisp/org-keys.el (org-mode-map): Bind `org-metaleft' to ESC by default, not just in terminals. This completes the ESC binding group. ESC , , and are already bound and missing ESC can be confusing. Reported in https://orgmode.org/list/Yf6lsTR3JSNSXRDX@x.local --- lisp/org-keys.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org-keys.el b/lisp/org-keys.el index 782ffa871..e96fa217b 100644 --- a/lisp/org-keys.el +++ b/lisp/org-keys.el @@ -462,6 +462,7 @@ (org-defkey org-mode-map (kbd "M-RET") #'org-meta-return) ;;;; Cursor keys with modifiers (org-defkey org-mode-map (kbd "M-") #'org-metaleft) +(org-defkey org-mode-map (kbd "ESC ") #'org-metaleft) (org-defkey org-mode-map (kbd "M-") #'org-metaright) (org-defkey org-mode-map (kbd "ESC ") #'org-metaright) (org-defkey org-mode-map (kbd "M-") #'org-metaup) -- 2.35.1 --=-=-=--