emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "Jonas Hörsch" <coroa@online.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] hide inline-tasks in 'children visibility state
Date: Thu, 31 Oct 2013 11:11:34 +0100	[thread overview]
Message-ID: <87li19agx5.fsf@gmail.com> (raw)
In-Reply-To: <87r4b23h1l.fsf@kafka.loc> ("Jonas \=\?utf-8\?Q\?H\=C3\=B6rsch\=22's\?\= message of "Wed, 30 Oct 2013 16:38:30 +0100")

Hello,

coroa@online.de (Jonas Hörsch) writes:

> one more patch, which takes care of re-hiding inline-tasks
> properly. finally it is possible to work with longer inline tasks
> without them getting always in the way.

Thank you for the patch. Here are a few comments.

> Subject: [PATCH] org-inlinetask: hide inline tasks in 'children visibility
>  state

Nitpick: you need a capital letter after colons.
>
> * lisp/org.el (org-cycle-hide-inline-tasks): re-hide inline tasks when
>   switching to 'children visibility state.

Ditto.

> +  "Re-hide inline tasks when switching to 'contents or 'children
> +visibility state."
> +  (cond ((eq state 'contents)

I suggest to use `case' here, but it's really a matter of style.

> +	 (when (and (boundp 'org-inlinetask-min-level)
> +		    org-inlinetask-min-level)

  (and (boundp 'var) var) => (org-bound-and-true-p var)

> +	   (hide-sublevels (1- org-inlinetask-min-level))))
> +	     (while (and (outline-next-heading)
> +			 (org-inlinetask-at-task-p))

I think it is more efficient to directly look for inlinetasks since you
can use `org-inlinetask-outline-regexp'.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2013-10-31 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 15:38 [PATCH] hide inline-tasks in 'children visibility state Jonas Hörsch
2013-10-31 10:11 ` Nicolas Goaziou [this message]
2013-11-04  8:52   ` Jonas Hörsch
2013-11-05 21:29     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li19agx5.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=coroa@online.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).