From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] hide inline-tasks in 'children visibility state
Date: Thu, 31 Oct 2013 11:11:34 +0100
Message-ID: <87li19agx5.fsf@gmail.com>
References: <87r4b23h1l.fsf@kafka.loc>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59802)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Vbq6R-0001oJ-FV
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 07:07:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Vbq6H-00075X-W1
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 07:07:51 -0400
Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:61337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VbpDh-0001Ph-NQ
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 06:11:17 -0400
Received: by mail-wg0-f51.google.com with SMTP id l18so2501081wgh.30
	for <emacs-orgmode@gnu.org>; Thu, 31 Oct 2013 03:11:16 -0700 (PDT)
In-Reply-To: <87r4b23h1l.fsf@kafka.loc> ("Jonas
	\=\?utf-8\?Q\?H\=C3\=B6rsch\=22's\?\= message of "Wed, 30
	Oct 2013 16:38:30 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jonas =?utf-8?Q?H=C3=B6rsch?= <coroa@online.de>
Cc: emacs-orgmode@gnu.org

Hello,

coroa@online.de (Jonas H=C3=B6rsch) writes:

> one more patch, which takes care of re-hiding inline-tasks
> properly. finally it is possible to work with longer inline tasks
> without them getting always in the way.

Thank you for the patch. Here are a few comments.

> Subject: [PATCH] org-inlinetask: hide inline tasks in 'children visibility
>  state

Nitpick: you need a capital letter after colons.
>
> * lisp/org.el (org-cycle-hide-inline-tasks): re-hide inline tasks when
>   switching to 'children visibility state.

Ditto.

> +  "Re-hide inline tasks when switching to 'contents or 'children
> +visibility state."
> +  (cond ((eq state 'contents)

I suggest to use `case' here, but it's really a matter of style.

> +	 (when (and (boundp 'org-inlinetask-min-level)
> +		    org-inlinetask-min-level)

  (and (boundp 'var) var) =3D> (org-bound-and-true-p var)

> +	   (hide-sublevels (1- org-inlinetask-min-level))))
> +	     (while (and (outline-next-heading)
> +			 (org-inlinetask-at-task-p))

I think it is more efficient to directly look for inlinetasks since you
can use `org-inlinetask-outline-regexp'.


Regards,

--=20
Nicolas Goaziou