emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "Jonas Hörsch" <coroa@online.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] hide inline-tasks in 'children visibility state
Date: Tue, 05 Nov 2013 22:29:35 +0100	[thread overview]
Message-ID: <87y552bkqo.fsf@gmail.com> (raw)
In-Reply-To: <87txfsczve.fsf@kafka.loc> ("Jonas \=\?utf-8\?Q\?H\=C3\=B6rsch\=22's\?\= message of "Mon, 04 Nov 2013 09:52:53 +0100")

Hello,

Jonas Hörsch <coroa@online.de> writes:

> On Thu, Oct 31 2013, Nicolas Goaziou wrote:
>
>> I suggest to use `case' here, but it's really a matter of style.
>
> fine with me. i wasn't sure about the usage convention for cl. i
> switched to the namespaced cl-case variant, for now.

It's better to use `case' as long as we support Emacs 23.

>> I think it is more efficient to directly look for inlinetasks since you
>> can use `org-inlinetask-outline-regexp'.
>
> hmm ... i'm not so sure. as you can see in the attached patch, now i
> have to perform an extra search on each headline to find the boundary
> for the inline task search. it feels to me like this would be faster for
> a situation with more than one inline task per headline in the mean?
> (which i don't think is the likely situation).
>
> well, what do you think?

You're right. Your first implementation is better in that regard. Could
you update that part so I can eventually apply it?

Thank you.


Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2013-11-05 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 15:38 [PATCH] hide inline-tasks in 'children visibility state Jonas Hörsch
2013-10-31 10:11 ` Nicolas Goaziou
2013-11-04  8:52   ` Jonas Hörsch
2013-11-05 21:29     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y552bkqo.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=coroa@online.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).