emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* ob-java and ob-haxe
@ 2020-09-02 11:56 ian martins
  2020-09-03  4:55 ` Kyle Meyer
  0 siblings, 1 reply; 10+ messages in thread
From: ian martins @ 2020-09-02 11:56 UTC (permalink / raw)
  To: Org-Mode mailing list

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

I posted patches for ob-java and ob-haxe a couple months ago but there was
no interest. I have been given access to push to contrib. If there's no
objection I'll put them there.

I'll rename my version ob-java-alt so it doesn't conflict with the official
one. The contrib directory doesn't have a "testing" directory so I'll add
one. I'll document them in worg.

-Ian

[-- Attachment #2: Type: text/html, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-02 11:56 ob-java and ob-haxe ian martins
@ 2020-09-03  4:55 ` Kyle Meyer
  2020-09-03 13:29   ` ian martins
  0 siblings, 1 reply; 10+ messages in thread
From: Kyle Meyer @ 2020-09-03  4:55 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

ian martins writes:

> I posted patches for ob-java and ob-haxe a couple months ago but there was
> no interest. I have been given access to push to contrib. If there's no
> objection I'll put them there.
>
> I'll rename my version ob-java-alt so it doesn't conflict with the official
> one. The contrib directory doesn't have a "testing" directory so I'll add
> one. I'll document them in worg.

My understanding is that there's been a move away from adding new
libraries to contrib/, instead preferring an ELPA for cases where core
isn't deemed appropriate.

Fixes and enhancements to ob-java are obviously appropriate for core.
And while it'd be fine to host ob-haxe separately, my impression is that
it too would be suitable for core.

I'm sorry your patches haven't gotten any reviews or other feedback.
I've sat down a couple of times to review the ob-haxe patch but haven't
ended up blocking off enough time to get anywhere.  I'll revisit it this
weekend.  Of course, any feedback from those that actually use haxe
would be appreciated.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-03  4:55 ` Kyle Meyer
@ 2020-09-03 13:29   ` ian martins
  2020-09-04  9:50     ` Bastien
  0 siblings, 1 reply; 10+ messages in thread
From: ian martins @ 2020-09-03 13:29 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Org-Mode mailing list

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

That is understandable; they're big patches. I recommend going over ob-java
first. Java is probably more familiar to you and ob-java and ob-haxe are
very similar. These were mostly based on ob-python and ob-C. The tests are
based on ob-Cs tests.

Look carefully at org-babel-temp-dir and
org-babel-remove-temporary-directory. The patches override core but ideally
these would be changes in core.

I was hesitant to put these in ELPA because then the tests won't run when
org-mode is modified.


On Thu, Sep 3, 2020 at 12:56 AM Kyle Meyer <kyle@kyleam.com> wrote:

> ian martins writes:
>
> > I posted patches for ob-java and ob-haxe a couple months ago but there
> was
> > no interest. I have been given access to push to contrib. If there's no
> > objection I'll put them there.
> >
> > I'll rename my version ob-java-alt so it doesn't conflict with the
> official
> > one. The contrib directory doesn't have a "testing" directory so I'll add
> > one. I'll document them in worg.
>
> My understanding is that there's been a move away from adding new
> libraries to contrib/, instead preferring an ELPA for cases where core
> isn't deemed appropriate.
>
> Fixes and enhancements to ob-java are obviously appropriate for core.
> And while it'd be fine to host ob-haxe separately, my impression is that
> it too would be suitable for core.
>
> I'm sorry your patches haven't gotten any reviews or other feedback.
> I've sat down a couple of times to review the ob-haxe patch but haven't
> ended up blocking off enough time to get anywhere.  I'll revisit it this
> weekend.  Of course, any feedback from those that actually use haxe
> would be appreciated.
>
>

[-- Attachment #2: Type: text/html, Size: 2186 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-03 13:29   ` ian martins
@ 2020-09-04  9:50     ` Bastien
  2020-09-05 11:34       ` ian martins
  0 siblings, 1 reply; 10+ messages in thread
From: Bastien @ 2020-09-04  9:50 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

Hi Ian,

thanks for your work on this.  Changes for ob-java.el should go in
core after the 9.4 release.  By the way, if you want to be ob-java.el
maintainer, that'd be appreciated too!

For ob-haxe.el, as Kyle suggests, let's prefer GNU ELPA (or upcoming
Non-GNU ELPA): Elisp files in contrib/ will be exfiltrated after 9.4.

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-04  9:50     ` Bastien
@ 2020-09-05 11:34       ` ian martins
  2020-09-05 13:04         ` Bastien
                           ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: ian martins @ 2020-09-05 11:34 UTC (permalink / raw)
  To: Bastien; +Cc: Org-Mode mailing list

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi Bastien,

Sure, I'd be happy to maintain ob-java.

The drawback with keeping ob-haxe in an external repo is that the tests
won't run when org-mode is changed, but in practice its tests are very
similar to ob-java's so the actual risk of it being broken by a change will
be small if ob-java is in core.

I'll submit ob-haxe to GNU ELPA after ob-java has been accepted. That way I
can take out the common parts of ob-haxe which will have been incorporated
into ob-core.


On Fri, Sep 4, 2020 at 5:50 AM Bastien <bzg@gnu.org> wrote:

> Hi Ian,
>
> thanks for your work on this.  Changes for ob-java.el should go in
> core after the 9.4 release.  By the way, if you want to be ob-java.el
> maintainer, that'd be appreciated too!
>
> For ob-haxe.el, as Kyle suggests, let's prefer GNU ELPA (or upcoming
> Non-GNU ELPA): Elisp files in contrib/ will be exfiltrated after 9.4.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 1346 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-05 11:34       ` ian martins
@ 2020-09-05 13:04         ` Bastien
  2020-09-05 13:43           ` ian martins
  2020-09-23 12:37         ` Bastien
  2020-09-23 12:38         ` Bastien
  2 siblings, 1 reply; 10+ messages in thread
From: Bastien @ 2020-09-05 13:04 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

Hi Ian,

ian martins <ianxm@jhu.edu> writes:

> Sure, I'd be happy to maintain ob-java.

Thanks!  Does your work on ob-java.el fix bugs or does it foremost
add new features?  If the former, we can add it now to master, then 
add you as a maintainer immediately.

> The drawback with keeping ob-haxe in an external repo is that the
> tests won't run when org-mode is changed, but in practice its tests
> are very similar to ob-java's so the actual risk of it being broken
> by a change will be small if ob-java is in core.
>
> I'll submit ob-haxe to GNU ELPA after ob-java has been accepted. That
> way I can take out the common parts of ob-haxe which will have been
> incorporated into ob-core.

Yes -- for now (< 9.4) we cannot accept changes in ob-core.el.

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-05 13:04         ` Bastien
@ 2020-09-05 13:43           ` ian martins
  2020-09-05 14:06             ` Bastien
  0 siblings, 1 reply; 10+ messages in thread
From: ian martins @ 2020-09-05 13:43 UTC (permalink / raw)
  To: Bastien; +Cc: Org-Mode mailing list

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

It primarily adds features.

It fixes the problem reported here [1] but that's probably not a common
problem and the person who reported it probably already migrated.

[1] https://orgmode.org/list/87d05nidu1.fsf@iki.fi/

On Sat, Sep 5, 2020 at 9:04 AM Bastien <bzg@gnu.org> wrote:

> Hi Ian,
>
> ian martins <ianxm@jhu.edu> writes:
>
> > Sure, I'd be happy to maintain ob-java.
>
> Thanks!  Does your work on ob-java.el fix bugs or does it foremost
> add new features?  If the former, we can add it now to master, then
> add you as a maintainer immediately.
>
> > The drawback with keeping ob-haxe in an external repo is that the
> > tests won't run when org-mode is changed, but in practice its tests
> > are very similar to ob-java's so the actual risk of it being broken
> > by a change will be small if ob-java is in core.
> >
> > I'll submit ob-haxe to GNU ELPA after ob-java has been accepted. That
> > way I can take out the common parts of ob-haxe which will have been
> > incorporated into ob-core.
>
> Yes -- for now (< 9.4) we cannot accept changes in ob-core.el.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 1695 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-05 13:43           ` ian martins
@ 2020-09-05 14:06             ` Bastien
  0 siblings, 0 replies; 10+ messages in thread
From: Bastien @ 2020-09-05 14:06 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

Hi Ian,

ian martins <ianxm@jhu.edu> writes:

> It primarily adds features.

Okay, thanks for the feedback, let's wait a bit then.

> It fixes the problem reported here [1] but that's probably not a
> common problem and the person who reported it probably already
> migrated.

Indeed.

Best,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-05 11:34       ` ian martins
  2020-09-05 13:04         ` Bastien
@ 2020-09-23 12:37         ` Bastien
  2020-09-23 12:38         ` Bastien
  2 siblings, 0 replies; 10+ messages in thread
From: Bastien @ 2020-09-23 12:37 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

Hi Ian,

ian martins <ianxm@jhu.edu> writes:

> Sure, I'd be happy to maintain ob-java.

thanks again for maintaining ob-java.el -- I've add you as the
maintainer in ob-java.el header.

Org 9.4 is out, feel free to push improvements.

Thanks!

-- 
 Bastien


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ob-java and ob-haxe
  2020-09-05 11:34       ` ian martins
  2020-09-05 13:04         ` Bastien
  2020-09-23 12:37         ` Bastien
@ 2020-09-23 12:38         ` Bastien
  2 siblings, 0 replies; 10+ messages in thread
From: Bastien @ 2020-09-23 12:38 UTC (permalink / raw)
  To: ian martins; +Cc: Org-Mode mailing list

ian martins <ianxm@jhu.edu> writes:

> I'll submit ob-haxe to GNU ELPA after ob-java has been accepted.

Thanks - I confirm contrib/ is not the place anymore for external
elisp packages, better to go on GNU ELPA.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-09-23 12:43 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 11:56 ob-java and ob-haxe ian martins
2020-09-03  4:55 ` Kyle Meyer
2020-09-03 13:29   ` ian martins
2020-09-04  9:50     ` Bastien
2020-09-05 11:34       ` ian martins
2020-09-05 13:04         ` Bastien
2020-09-05 13:43           ` ian martins
2020-09-05 14:06             ` Bastien
2020-09-23 12:37         ` Bastien
2020-09-23 12:38         ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).