From: Joseph Turner <joseph@breatheoutbreathe.in>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output
Date: Sat, 13 Aug 2022 22:30:20 -0700 [thread overview]
Message-ID: <87ilmv9yst.fsf@breatheoutbreathe.in> (raw)
In-Reply-To: <87o7wxlqdr.fsf@localhost>
You're right! Thank you for catching my mistake. I'll send another patch.
Joseph
Ihor Radchenko <yantar92@gmail.com> writes:
> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
>> Document the new functionality of ob-plantuml to insert ASCII diagrams
>> directly in the buffer.
>
> Thanks!
>
>> -=PlantUML= requires a working
>> [[https://www.java.com/en/download/][Java]] installation and access
>> to the
>> -=plantuml.jar= component. A working [[https://graphviz.org/][GraphViz]] installation is required
>> -for many diagrams.
>> +=PlantUML= blocks can be executed in one of three ways, requiring either
>> +
>> +- a working [[https://www.java.com/en/download/][Java]]
>> installation and access to the =plantuml.jar= component or
>> +- the =plantuml= executable available from your distribution's package manager or
>> +- a connection to a remote [[https://github.com/plantuml/plantuml-server][PlantUML server]]
>
> I do not think that ob-plantuml.el supports server connections. We may
> need to clarify that server part and plantuml-* variables have nothing
> to do with ob-plantuml per se.
>
> Otherwise, the patch looks good.
next prev parent reply other threads:[~2022-08-14 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 21:42 [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output Joseph Turner
2022-08-06 8:37 ` Ihor Radchenko
2022-08-14 5:30 ` Joseph Turner [this message]
2022-09-15 9:32 ` Ihor Radchenko
2022-09-15 9:33 ` Ihor Radchenko
2022-09-15 16:23 ` Joseph Turner
2022-09-21 9:19 ` Joseph Turner
2022-09-22 12:18 ` [BUG] Server-side export problem in Worg? (was: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output) Ihor Radchenko
2022-09-22 14:03 ` Max Nikulin
2022-09-22 15:36 ` [BUG] Server-side export problem in Worg? Bastien Guerry
2022-09-22 23:53 ` Joseph Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilmv9yst.fsf@breatheoutbreathe.in \
--to=joseph@breatheoutbreathe.in \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).