emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output
Date: Sat, 06 Aug 2022 16:37:04 +0800	[thread overview]
Message-ID: <87o7wxlqdr.fsf@localhost> (raw)
In-Reply-To: <20220805214214.25723-1-joseph@breatheoutbreathe.in>

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Document the new functionality of ob-plantuml to insert ASCII diagrams
> directly in the buffer.

Thanks!

> -=PlantUML= requires a working [[https://www.java.com/en/download/][Java]] installation and access to the
> -=plantuml.jar= component.  A working [[https://graphviz.org/][GraphViz]] installation is required
> -for many diagrams.
> +=PlantUML= blocks can be executed in one of three ways, requiring either
> +
> +- a working [[https://www.java.com/en/download/][Java]] installation and access to the =plantuml.jar= component or
> +- the =plantuml= executable available from your distribution's package manager or
> +- a connection to a remote [[https://github.com/plantuml/plantuml-server][PlantUML server]]

I do not think that ob-plantuml.el supports server connections. We may
need to clarify that server part and plantuml-* variables have nothing
to do with ob-plantuml per se.

Otherwise, the patch looks good.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

next prev parent reply	other threads:[~2022-08-06  8:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 21:42 [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output Joseph Turner
2022-08-06  8:37 ` Ihor Radchenko [this message]
2022-08-14  5:30   ` Joseph Turner
2022-09-15  9:32     ` Ihor Radchenko
2022-09-15  9:33       ` Ihor Radchenko
2022-09-15 16:23         ` Joseph Turner
2022-09-21  9:19           ` Joseph Turner
2022-09-22 12:18             ` [BUG] Server-side export problem in Worg? (was: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output) Ihor Radchenko
2022-09-22 14:03               ` Max Nikulin
2022-09-22 15:36               ` [BUG] Server-side export problem in Worg? Bastien Guerry
2022-09-22 23:53                 ` Joseph Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7wxlqdr.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=joseph@breatheoutbreathe.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).