From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJ4oM/yI+GL1UAEAbAwnHQ (envelope-from ) for ; Sun, 14 Aug 2022 07:32:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kB8nM/yI+GIc6wAA9RJhRA (envelope-from ) for ; Sun, 14 Aug 2022 07:32:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DC2518F38 for ; Sun, 14 Aug 2022 07:32:44 +0200 (CEST) Received: from localhost ([::1]:55894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oN6Et-0007BZ-8R for larch@yhetil.org; Sun, 14 Aug 2022 01:32:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN6DN-0007AS-E0 for emacs-orgmode@gnu.org; Sun, 14 Aug 2022 01:31:09 -0400 Received: from out0.migadu.com ([94.23.1.103]:61502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN6DJ-0003Fx-EI for emacs-orgmode@gnu.org; Sun, 14 Aug 2022 01:31:08 -0400 References: <20220805214214.25723-1-joseph@breatheoutbreathe.in> <87o7wxlqdr.fsf@localhost> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1660455060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zWyUs+lPy1yHo2fROQF03kuiO+X9LxZ3kV2IQXycvD8=; b=A/UKXhzF517lXAwGk2xf7ePaHsXwko3HvtfgDQq6JBHHoi8u2DUrLPxTVSt8vs6pkGAEaQ es0Ekibci08aUm/2YG3mYBkPSLq1sDo0Be+VBQxMunmXfiyl8ZPPWxL7L0tG8eamTU+MX7 F8uO3709J99Oiu2DWdFxsfhR8j8tnZ8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output Date: Sat, 13 Aug 2022 22:30:20 -0700 In-reply-to: <87o7wxlqdr.fsf@localhost> Message-ID: <87ilmv9yst.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=94.23.1.103; envelope-from=joseph@breatheoutbreathe.in; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660455164; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zWyUs+lPy1yHo2fROQF03kuiO+X9LxZ3kV2IQXycvD8=; b=RVcXrSQEkVarjTAsmAzhA/N2XnrPpnqWMBGFhfBK5rtcXYukQ8U5dfELlP1T5J5XDTMIcf hLPdHPrQGeczv+ilPRCobjRkYTngf0tKf1jNghk5vIlpLP9hRg4hqC7OFitcZvQmik2VaQ 5rfY+zC8LuDMLxqMTcWcmHLaTuzE758zPu8wCCfniaXyo2oxcRemdnP6FNnUcVyXGl4LTY rJPMrbwLAbch9G/2d5Q8vTjJwSOD9KiI3ymKAkUqGiJ/OVQB+RVOvCxX9M5V8lzgQuxxEW pmW9PLJCLD9SmmZ2sTTLtdsmlVVusL2fgIyQMGnKPZZC9ke3HZnWb3IHjviPvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660455164; a=rsa-sha256; cv=none; b=NP5jq+eh+1NSwv70h1IG+gHsiQNyKV64u4r73b/XLeNhG8HETarnYieqXAuMpDlLgd0XfE qG4717Amr4R2O9Og8UQ2ARhYTehAv9+m9iEvKM60+z3ykmXxgKng3KXfWsG3QZeWYoCa3o XXVaLp/1fML17FjtLeTRlD3EUh0x3fx6JuSU5UxLbA0SSXQrIvlSq03S6uTDXqDdjyp6xc RvhZew99LqNo1ctYvnfTo6wHujoi3M5+BW45adUDskBfUuIoI50Ng87xZkFNtQbrSnssgR /yURiDLsYialjd96hbNgd+gIGN0zK+81DuF6KWdL2Iaej3fGP5FlqUGQsgNTcw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b="A/UKXhzF"; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.76 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b="A/UKXhzF"; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5DC2518F38 X-Spam-Score: -8.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: g9j1NakUtUUh You're right! Thank you for catching my mistake. I'll send another patch. Joseph Ihor Radchenko writes: > Joseph Turner writes: > >> Document the new functionality of ob-plantuml to insert ASCII diagrams >> directly in the buffer. > > Thanks! > >> -=PlantUML= requires a working >> [[https://www.java.com/en/download/][Java]] installation and access >> to the >> -=plantuml.jar= component. A working [[https://graphviz.org/][GraphViz]] installation is required >> -for many diagrams. >> +=PlantUML= blocks can be executed in one of three ways, requiring either >> + >> +- a working [[https://www.java.com/en/download/][Java]] >> installation and access to the =plantuml.jar= component or >> +- the =plantuml= executable available from your distribution's package manager or >> +- a connection to a remote [[https://github.com/plantuml/plantuml-server][PlantUML server]] > > I do not think that ob-plantuml.el supports server connections. We may > need to clarify that server part and plantuml-* variables have nothing > to do with ob-plantuml per se. > > Otherwise, the patch looks good.