emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [RFC/PATCH] org-goto: Update for isearch changes
Date: Sun, 02 Nov 2014 23:27:07 +0100	[thread overview]
Message-ID: <87h9yhgrwk.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87d295uw5g.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 02 Nov 2014 16:31:39 -0500")

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> As of Emacs 24.4, isearch no longer has the function
> isearch-other-control-char, which is bound in
> org-goto-local-auto-isearch-map.
>
> I've attached a patch that seems to produce the correct behavior with
> Emacs 24.4. However, I haven't used this interface enough in the past (I
> have org-goto-interface set to 'outline-path-completion') to be
> confident that the patch keeps the intended behavior.

C-i and C-m seem to work out the box in Emacs 24.4 anyway. Maybe the
following is sufficient:

  (when (fboundp 'isearch-other-control-char)
    (define-key ...)
    (define-key ...))

I.e, no need to bind these keys to nil.

Also, you should add a comment about deprecation once we drop support
for emacs 24.3.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2014-11-02 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 21:31 [RFC/PATCH] org-goto: Update for isearch changes Kyle Meyer
2014-11-02 22:27 ` Nicolas Goaziou [this message]
2014-11-02 22:44   ` Kyle Meyer
2014-11-02 23:33     ` Nicolas Goaziou
2014-11-02 23:56       ` Kyle Meyer
2014-11-03  5:12         ` Kyle Meyer
2014-11-03  8:29           ` Nicolas Goaziou
2014-11-03 16:58             ` Kyle Meyer
2014-11-03 20:11               ` Nicolas Goaziou
2014-11-03 20:19                 ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9yhgrwk.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).