emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [RFC/PATCH] org-goto: Update for isearch changes
Date: Mon, 03 Nov 2014 00:12:42 -0500	[thread overview]
Message-ID: <87egtkop1p.fsf@kmlap.domain.org> (raw)
In-Reply-To: <8738a1upft.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 02 Nov 2014 18:56:38 -0500")

Kyle Meyer <kyle@kyleam.com> wrote:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> [...]
>> However, C-m is RET. Is there any reason to distinguish between the two?
>
> If I use just
>
>     (define-key org-goto-local-auto-isearch-map [return] nil)
>
> then C-m doesn't work (i.e., it results in isearch-exit being called
> instead of org-goto-ret, then requiring a second key press to get out of
> the org-goto indirect buffer). The same is true for return if only the
> C-m line is used.

To follow up on this:

I think the reason why setting only one doesn't work is because isearch
specifies both of them.

    (define-key map "\r" 'isearch-exit)
    (define-key map [return] 'isearch-exit)

Since the return key is given a binding, it's not translated to the
corresponding ASCII character and, as a result, needs to be overridden
specifically. At least, that's my understanding based on
(info "(emacs)Named ASCII Chars").

--
Kyle

next prev parent reply	other threads:[~2014-11-03  5:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 21:31 [RFC/PATCH] org-goto: Update for isearch changes Kyle Meyer
2014-11-02 22:27 ` Nicolas Goaziou
2014-11-02 22:44   ` Kyle Meyer
2014-11-02 23:33     ` Nicolas Goaziou
2014-11-02 23:56       ` Kyle Meyer
2014-11-03  5:12         ` Kyle Meyer [this message]
2014-11-03  8:29           ` Nicolas Goaziou
2014-11-03 16:58             ` Kyle Meyer
2014-11-03 20:11               ` Nicolas Goaziou
2014-11-03 20:19                 ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egtkop1p.fsf@kmlap.domain.org \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).