From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [RFC/PATCH] org-goto: Update for isearch changes Date: Mon, 03 Nov 2014 00:12:42 -0500 Message-ID: <87egtkop1p.fsf@kmlap.domain.org> References: <87d295uw5g.fsf@kyleam.com> <87h9yhgrwk.fsf@nicolasgoaziou.fr> <87r3xlnrxn.fsf@kyleam.com> <87oaspfa8t.fsf@nicolasgoaziou.fr> <8738a1upft.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9uU-00037P-9Z for emacs-orgmode@gnu.org; Mon, 03 Nov 2014 00:10:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl9uP-000846-Uf for emacs-orgmode@gnu.org; Mon, 03 Nov 2014 00:10:34 -0500 Received: from mail-qg0-f41.google.com ([209.85.192.41]:52442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9uP-000838-PT for emacs-orgmode@gnu.org; Mon, 03 Nov 2014 00:10:29 -0500 Received: by mail-qg0-f41.google.com with SMTP id q107so8333278qgd.28 for ; Sun, 02 Nov 2014 21:10:29 -0800 (PST) Received: from localhost ([2601:6:5480:1e5:9e4e:36ff:fe3d:ae9c]) by mx.google.com with ESMTPSA id c40sm16042683qge.6.2014.11.02.21.10.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Nov 2014 21:10:28 -0800 (PST) In-Reply-To: <8738a1upft.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 02 Nov 2014 18:56:38 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org-mode Kyle Meyer wrote: > Nicolas Goaziou wrote: > [...] >> However, C-m is RET. Is there any reason to distinguish between the two? > > If I use just > > (define-key org-goto-local-auto-isearch-map [return] nil) > > then C-m doesn't work (i.e., it results in isearch-exit being called > instead of org-goto-ret, then requiring a second key press to get out of > the org-goto indirect buffer). The same is true for return if only the > C-m line is used. To follow up on this: I think the reason why setting only one doesn't work is because isearch specifies both of them. (define-key map "\r" 'isearch-exit) (define-key map [return] 'isearch-exit) Since the return key is given a binding, it's not translated to the corresponding ASCII character and, as a result, needs to be overridden specifically. At least, that's my understanding based on (info "(emacs)Named ASCII Chars"). -- Kyle