From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC/PATCH] org-goto: Update for isearch changes Date: Sun, 02 Nov 2014 23:27:07 +0100 Message-ID: <87h9yhgrwk.fsf@nicolasgoaziou.fr> References: <87d295uw5g.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl3bN-0002h7-JZ for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:26:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl3bG-0008ID-Qh for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:26:25 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:37591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl3bG-0008I1-Ku for emacs-orgmode@gnu.org; Sun, 02 Nov 2014 17:26:18 -0500 In-Reply-To: <87d295uw5g.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 02 Nov 2014 16:31:39 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: Org-mode Hello, Kyle Meyer writes: > As of Emacs 24.4, isearch no longer has the function > isearch-other-control-char, which is bound in > org-goto-local-auto-isearch-map. > > I've attached a patch that seems to produce the correct behavior with > Emacs 24.4. However, I haven't used this interface enough in the past (I > have org-goto-interface set to 'outline-path-completion') to be > confident that the patch keeps the intended behavior. C-i and C-m seem to work out the box in Emacs 24.4 anyway. Maybe the following is sufficient: (when (fboundp 'isearch-other-control-char) (define-key ...) (define-key ...)) I.e, no need to bind these keys to nil. Also, you should add a comment about deprecation once we drop support for emacs 24.3. Regards, -- Nicolas Goaziou