From: No Wayman <iarchivedmywholelife@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, Allen Li <darkfeline@felesatra.moe>
Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)]
Date: Mon, 27 Sep 2021 11:56:00 -0400 [thread overview]
Message-ID: <87h7e6dluc.fsf@gmail.com> (raw)
In-Reply-To: <87k0j23tnu.fsf@gnu.org>
Bastien <bzg@gnu.org> writes:
> Hi,
>
> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
> Instead of a defvar that we don't want the user to modify, why
> not
> hardcoding the addition of the coma? I'd prefer this.
`completing-read-multiple' is currently used in two spots to read
tags:
`org-set-tags-command' and `org-capture-fill-template'.
To be clear, you would rather I hard code the same regexp and
comment in those two locations rather than abstracting it into a
defconst?
> Any place in the manual that refers to tag separators,
> explicitly or
> implicitly, I've not checked if there are some. Also in the
> code
> itself, as a comment, to explain why both "," and ":" should be
> allowed
I don't see why we need to add anything to the manual.
We're not changing the syntax of tags.
We're utilizing the normal behavior of completing-read-multiple.
The manual states for `org-set-tags-command':
"By default Org mode uses the standard minibuffer completion
facilities for entering tags."
The comma is standard when reading multiple items.
That seems to cover it to me.
Another solution I proposed was indicating the delimiters in the
minibuffer prompt similar to what is currently done in
`org-todo-list'.
e.g.
org-todo-list prompt: "Keyword (or KWD1|KWD2|...): "
org-set-tags-command prompt: "Tags ("," or ":" to delimit): "
The only argument I heard against that was from one person who
thought it "wasted space".
I don't consider that a strong argument considering the length of
the prompt for `org-todo-list'.
>(avoid the keyboard-based argument, which is too subjective.)
If one can customize their keyboard layout, I don't see why we
should be so rigid about a delimiter in a prompt.
It's a moot point, though, I've abandoned that proposal because it
was apparently too controversial.
next prev parent reply other threads:[~2021-09-27 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 17:04 [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2021-08-31 10:17 ` Timothy
2021-09-03 2:05 ` No Wayman
2021-09-03 7:22 ` Timothy
2021-09-03 17:00 ` No Wayman
2021-09-03 6:51 ` Allen Li
2021-09-03 8:08 ` Timothy
2021-09-03 19:20 ` No Wayman
2021-09-17 17:09 ` No Wayman
2021-09-03 17:13 ` No Wayman
2021-09-03 19:42 ` No Wayman
2021-09-03 23:37 ` No Wayman
2021-09-27 8:35 ` Bastien
2021-09-27 15:19 ` No Wayman
2021-09-27 15:49 ` Bastien
2021-09-27 15:56 ` No Wayman [this message]
2021-09-06 0:48 ` Allen Li
2021-09-06 23:23 ` No Wayman
2021-09-12 3:37 ` Allen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7e6dluc.fsf@gmail.com \
--to=iarchivedmywholelife@gmail.com \
--cc=bzg@gnu.org \
--cc=darkfeline@felesatra.moe \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).