From: Bastien <bzg@gnu.org>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org, Allen Li <darkfeline@felesatra.moe>
Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)]
Date: Mon, 27 Sep 2021 17:49:41 +0200 [thread overview]
Message-ID: <87k0j23tnu.fsf@gnu.org> (raw)
In-Reply-To: <87lf3idnz6.fsf@gmail.com> (No Wayman's message of "Mon, 27 Sep 2021 11:19:56 -0400")
Hi,
No Wayman <iarchivedmywholelife@gmail.com> writes:
> The patch you are viewing is outdated.
> This is the latest patch on offer:
>
> https://list.orgmode.org/87bl4rce4j.fsf@gmail.com/2-0001-Allow-to-delimit-tags.patch
Thanks.
> It allows "," (the default for completing-read-multiple) and ":" to
> delimit tags when completing-read-multiple is used.
What does not work if we don't allow ","?
> The reason for allowing "," is that it's easier to type than ":". I
> make liberal use of tags and IMO typing a "Shift+;" between each tag
> is annoying and slow.
Okay (but note that we don't all use the same keyboard...)
> The comma is also used as the default separator when
> completing-read-multiple is used.
>
>> If we relax a constraint, I'd rather have this hardcoded and well
>> documented than adding a new defvar or defcustom.
>
> The latest patch removed the defcustom and replaced it with a defvar
> for the crm-separator regexp.
> If it would ease your mind I'd be happy to convert it to a defconst.
Instead of a defvar that we don't want the user to modify, why not
hardcoding the addition of the coma? I'd prefer this.
> It's also worth noting that the constraint was only recently
> introduced.
> "," worked fine to delimit tags in `org-set-tags-command' prior to the
> switch to completing-read-multiple.
Okay, this buys it - if I understand what really does not work when
allowing ":".
> Regarding documentation, let me know where you'd prefer it
> documented.
Any place in the manual that refers to tag separators, explicitely or
implicitely, I've not checked if there are some. Also in the code
itself, as a comment, to explain why both "," and ":" should be
allowed (avoid the keyboard-based argument, which is too subjective.)
Thanks!
--
Bastien
next prev parent reply other threads:[~2021-09-27 15:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 17:04 [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2021-08-31 10:17 ` Timothy
2021-09-03 2:05 ` No Wayman
2021-09-03 7:22 ` Timothy
2021-09-03 17:00 ` No Wayman
2021-09-03 6:51 ` Allen Li
2021-09-03 8:08 ` Timothy
2021-09-03 19:20 ` No Wayman
2021-09-17 17:09 ` No Wayman
2021-09-03 17:13 ` No Wayman
2021-09-03 19:42 ` No Wayman
2021-09-03 23:37 ` No Wayman
2021-09-27 8:35 ` Bastien
2021-09-27 15:19 ` No Wayman
2021-09-27 15:49 ` Bastien [this message]
2021-09-27 15:56 ` No Wayman
2021-09-06 0:48 ` Allen Li
2021-09-06 23:23 ` No Wayman
2021-09-12 3:37 ` Allen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0j23tnu.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=darkfeline@felesatra.moe \
--cc=emacs-orgmode@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).