From: Allen Li <darkfeline@felesatra.moe>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)]
Date: Sat, 11 Sep 2021 20:37:51 -0700 [thread overview]
Message-ID: <80v936qx9s.fsf@felesatra.moe> (raw)
In-Reply-To: <87fsuhi7o2.fsf@gmail.com> (No Wayman's message of "Mon, 06 Sep 2021 19:23:36 -0400")
No Wayman <iarchivedmywholelife@gmail.com> writes:
>> Yes, I think using only ":" and "," is the best default option. I
>> still
>> don't think there is a need to make it customizable (I doubt anyone
>> is
>> typing tags separated with ! or @ or #), but I suppose
>> there's minimal harm from doing so.
>
> I don't see the need to prevent customization here, either.
> There may be use cases we don't anticiapte and it adds very little in
> the way of maitenance.
> Consider if the author of crm.el decided to hardcode the separator.
> Your original patch would not have been so trivial.
crm.el is a library whose purpose is to provide a customizable
completion API. That's not comparable to Org mode's tag setting commands.
>
>> I am -0.5 on showing the delimiters since this is not conventional
>> for
>> completing-read-multiple, especially after we add support for ","
>> like
>> most other uses of completing-read-multiple. It needlessly inflates
>> the
>> length of the prompt.
>
> I don't know what you mean by -0.5, but I wouldn't say it's needless.
> `org-todo-list' adds the following to the prompt:
>
>> "Keyword (or KWD1|KWD2|...): "
>
> We're talking a handful of characters at most. e.g.
>
>> "Tags (: , to delimit): "
>
> Actually shorter than what `org-todo-list' does now.
> I'm open to suggestions on improving that prompt format as well.
-0.5 means slightly against (+1 means agree and -1 means disagree).
> So it looks like the remaining issue is whether or not it's worth
> displaying the tag delimiters in the prompt. I'll think on it some
> more and give it some time to see if anyone else has any arguments in
> favor or against the idea. If I don't see anything by the weekend,
> I'll amend the patch with the changes suggested above.
I don't want to bikeshed it further since it is not that important and
not worth either of our time. I have already stated my reasons that I
would personally not add these things, but it does not bother me enough,
nor is it significant enough to spend more time on.
Whether to make the delimiters customizable: No, because I don't think
there's a need. Maybe one Org mode user will need it and they can
define their own command.
Whether to display separators in prompt: No, because both , and : are
intuitive, and also no if delimiters are customizable since the user
knows what the delimiters are (since they set them).
prev parent reply other threads:[~2021-09-12 3:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 17:04 [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2021-08-31 10:17 ` Timothy
2021-09-03 2:05 ` No Wayman
2021-09-03 7:22 ` Timothy
2021-09-03 17:00 ` No Wayman
2021-09-03 6:51 ` Allen Li
2021-09-03 8:08 ` Timothy
2021-09-03 19:20 ` No Wayman
2021-09-17 17:09 ` No Wayman
2021-09-03 17:13 ` No Wayman
2021-09-03 19:42 ` No Wayman
2021-09-03 23:37 ` No Wayman
2021-09-27 8:35 ` Bastien
2021-09-27 15:19 ` No Wayman
2021-09-27 15:49 ` Bastien
2021-09-27 15:56 ` No Wayman
2021-09-06 0:48 ` Allen Li
2021-09-06 23:23 ` No Wayman
2021-09-12 3:37 ` Allen Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80v936qx9s.fsf@felesatra.moe \
--to=darkfeline@felesatra.moe \
--cc=emacs-orgmode@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).