From: Bastien <bzg@gnu.org>
To: Ivan Kanis <banana@kanis.fr>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] fix appointment warn time
Date: Fri, 26 Apr 2013 19:01:22 +0200 [thread overview]
Message-ID: <87fvydb50d.fsf@bzg.ath.cx> (raw)
In-Reply-To: <m0vc79l114.fsf@kanis.fr> (Ivan Kanis's message of "Fri, 26 Apr 2013 18:17:11 +0200")
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi Ivan,
Ivan Kanis <banana@kanis.fr> writes:
> It seemed to be a boundary error. (point) was at the end of the
> timestamp which doesn't hold the org-appt-warntime property.
It does not hold the text property until this property has been
set. E.g., `org-agenda-prepare-buffers' sets this property.
So I'm still curious: under which circumstances do you expect
APPT_WARNTIME to have an effect while it does not?
`org-agenda-to-appt' do refresh the 'org-appt-warntime property,
so it will not appear here.
> foo.org illustrate what I have seen. Evaling the get-property sexp
> returns nil.
Yep, as expected.
> The patch adds a function that goes at the beginning of the header to
> get the property. As a bonus it turns the string into a number.
>
> Please let me know if the patch is accepted or needs improvement.
Can you try the attached patch instead?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.el.patch --]
[-- Type: text/x-patch, Size: 362 bytes --]
diff --git a/lisp/org.el b/lisp/org.el
index 2bb6127..fe64f14 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9245,7 +9245,7 @@ property to set."
(save-excursion
(org-back-to-heading t)
(put-text-property
- (point-at-bol) (point-at-eol) tprop p))))))))
+ (point-at-bol) (org-end-of-subtree t t) tprop p))))))))
;;;; Link Stuff
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
next prev parent reply other threads:[~2013-04-26 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 16:17 [PATCH] fix appointment warn time Ivan Kanis
2013-04-26 17:01 ` Bastien [this message]
2013-04-27 8:34 ` Ivan Kanis
2013-04-27 12:02 ` Bastien
2013-04-28 8:48 ` Ivan Kanis
2013-04-28 8:59 ` Bastien
2013-04-28 19:57 ` Ivan Kanis
2013-05-14 8:36 ` Bastien
2013-05-14 11:46 ` Ivan Kanis
2013-05-14 11:49 ` Bastien
2013-05-14 12:10 ` Ivan Kanis
2013-05-14 13:20 ` Miguel Ruiz
2013-05-14 14:08 ` Bastien
2013-05-14 15:06 ` Ivan Kanis
2013-05-14 15:18 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvydb50d.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=banana@kanis.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).