From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] fix appointment warn time Date: Fri, 26 Apr 2013 19:01:22 +0200 Message-ID: <87fvydb50d.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVm1a-00083V-Ht for emacs-orgmode@gnu.org; Fri, 26 Apr 2013 13:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVm1Z-0001F5-8w for emacs-orgmode@gnu.org; Fri, 26 Apr 2013 13:01:30 -0400 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:54001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVm1Z-0001Ez-3N for emacs-orgmode@gnu.org; Fri, 26 Apr 2013 13:01:29 -0400 Received: by mail-wg0-f53.google.com with SMTP id z11so2347505wgg.32 for ; Fri, 26 Apr 2013 10:01:28 -0700 (PDT) In-Reply-To: (Ivan Kanis's message of "Fri, 26 Apr 2013 18:17:11 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ivan Kanis Cc: org mode --=-=-= Content-Type: text/plain Hi Ivan, Ivan Kanis writes: > It seemed to be a boundary error. (point) was at the end of the > timestamp which doesn't hold the org-appt-warntime property. It does not hold the text property until this property has been set. E.g., `org-agenda-prepare-buffers' sets this property. So I'm still curious: under which circumstances do you expect APPT_WARNTIME to have an effect while it does not? `org-agenda-to-appt' do refresh the 'org-appt-warntime property, so it will not appear here. > foo.org illustrate what I have seen. Evaling the get-property sexp > returns nil. Yep, as expected. > The patch adds a function that goes at the beginning of the header to > get the property. As a bonus it turns the string into a number. > > Please let me know if the patch is accepted or needs improvement. Can you try the attached patch instead? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=org.el.patch diff --git a/lisp/org.el b/lisp/org.el index 2bb6127..fe64f14 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -9245,7 +9245,7 @@ property to set." (save-excursion (org-back-to-heading t) (put-text-property - (point-at-bol) (point-at-eol) tprop p)))))))) + (point-at-bol) (org-end-of-subtree t t) tprop p)))))))) ;;;; Link Stuff --=-=-= Content-Type: text/plain -- Bastien --=-=-=--