emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Matthew MacLean <archenoth@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby
Date: Wed, 12 Aug 2015 01:53:48 -0400	[thread overview]
Message-ID: <87fv3pxdar.fsf@kmlap.domain.org> (raw)
In-Reply-To: <CA+GZiYpLamH4eXjRGUpgOspPdbjAJhUjuapnU6njgWKi8hgmsQ@mail.gmail.com> (Matthew MacLean's message of "Tue, 11 Aug 2015 21:24:13 -0600")

Matthew MacLean <archenoth@gmail.com> wrote:
[...]
> ...here is the git format-patch of the ob-ruby.el change!

> I also created one for a test to check for basic Ruby evaluation
> capabilities. It should catch errors that break evaluation like this in
> ob-ruby.

Thanks.  The code change looks good to me and fixes the provided test.

Please format the commit message like described here:

  http://orgmode.org/worg/org-contribute.html#orgheadline6

In addition to the formatting, the message should include "TINYCHANGE".
This may be beyond what qualifies as a tiny change if tests count toward
changed lines (Bastien or Nicolas?).  If it's acceptable as a tiny
change, please combine the two commits.  Otherwise, perhaps we can just
leave the test commit out.

> (I find it interesting that the session tests worked without the
> double-escape change actually.)

The session tests never execute a branch that calls
org-babel-ruby-table-or-string.

--
Kyle

next prev parent reply	other threads:[~2015-08-12  5:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 20:52 fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby Matthew MacLean
2015-08-11 22:33 ` Kyle Meyer
2015-08-11 22:36   ` Kyle Meyer
2015-08-11 22:46     ` Matthew MacLean
2015-08-12  0:52       ` Kyle Meyer
2015-08-12  3:24         ` Matthew MacLean
2015-08-12  5:53           ` Kyle Meyer [this message]
2015-08-12  6:18             ` Matthew MacLean
2015-08-12 17:21               ` Kyle Meyer
2015-08-12 20:05                 ` Matthew MacLean
2015-08-13  3:41                   ` Kyle Meyer
2015-08-13  4:02                     ` Matthew MacLean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv3pxdar.fsf@kmlap.domain.org \
    --to=kyle@kyleam.com \
    --cc=archenoth@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).