From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape
 for ob-ruby
Date: Wed, 12 Aug 2015 01:53:48 -0400
Message-ID: <87fv3pxdar.fsf@kmlap.domain.org>
References: <CA+GZiYozqNe7T+A3_n0x=bEV3bPBcGn2zpmwxK5Zc2EDS6jnHQ@mail.gmail.com>
	<87h9o5316t.fsf@kyleam.com> <87bned311f.fsf@kyleam.com>
	<CA+GZiYp19iQ1giRpc=3XjN_eXh_NGXn2XSi6JHWzia=oLvAJYw@mail.gmail.com>
	<874mk5coqy.fsf@kmlap.domain.org>
	<CA+GZiYpLamH4eXjRGUpgOspPdbjAJhUjuapnU6njgWKi8hgmsQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPOz4-0004tp-TT
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 01:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPOz1-0007SU-JX
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 01:53:54 -0400
Received: from mail-qg0-f41.google.com ([209.85.192.41]:35838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPOz1-0007SN-Fh
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 01:53:51 -0400
Received: by qgj62 with SMTP id 62so4573380qgj.2
	for <emacs-orgmode@gnu.org>; Tue, 11 Aug 2015 22:53:50 -0700 (PDT)
In-Reply-To: <CA+GZiYpLamH4eXjRGUpgOspPdbjAJhUjuapnU6njgWKi8hgmsQ@mail.gmail.com>
	(Matthew MacLean's message of "Tue, 11 Aug 2015 21:24:13 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matthew MacLean <archenoth@gmail.com>
Cc: emacs-orgmode@gnu.org

Matthew MacLean <archenoth@gmail.com> wrote:
[...]
> ...here is the git format-patch of the ob-ruby.el change!

> I also created one for a test to check for basic Ruby evaluation
> capabilities. It should catch errors that break evaluation like this in
> ob-ruby.

Thanks.  The code change looks good to me and fixes the provided test.

Please format the commit message like described here:

  http://orgmode.org/worg/org-contribute.html#orgheadline6

In addition to the formatting, the message should include "TINYCHANGE".
This may be beyond what qualifies as a tiny change if tests count toward
changed lines (Bastien or Nicolas?).  If it's acceptable as a tiny
change, please combine the two commits.  Otherwise, perhaps we can just
leave the test commit out.

> (I find it interesting that the session tests worked without the
> double-escape change actually.)

The session tests never execute a branch that calls
org-babel-ruby-table-or-string.

--
Kyle