emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Matthew MacLean <archenoth@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby
Date: Tue, 11 Aug 2015 18:33:30 -0400	[thread overview]
Message-ID: <87h9o5316t.fsf@kyleam.com> (raw)
In-Reply-To: <CA+GZiYozqNe7T+A3_n0x=bEV3bPBcGn2zpmwxK5Zc2EDS6jnHQ@mail.gmail.com> (Matthew MacLean's message of "Tue, 11 Aug 2015 14:52:39 -0600")

Matthew MacLean <archenoth@gmail.com> wrote:
> Yo~!
>
> fa5fd6351605912ec75e783cb626497b1ebe471e introduced a change where
> org-babel-script-escape stopped accepting numbers. This caused an issue in
> ob-ruby.el where when trying to evaluate something like "2 + 2", you would
> get the message:
>
>   `org-babel-script-escape' expects a string
>
> This broke evaluation of Ruby code blocks.
>
> I suspect this is not the only location where this problem might
> arise,

Perhaps ob-ruby.el is to blame.

#+begin_src ruby
  2 + 2
#+end_src

The above snippet calls org-babel-script-escape twice: first with "4"
and then with 4.  The first one happens with the org-babel-ruby-evaluate
call (which leads to an org-babel-ruby-table-or-string call) in
org-babel-execute:ruby and the second happens with the direct call to
org-babel-ruby-table-or-string in org-babel-execute:ruby.

Is the results-params check and call to org-babel-ruby-table-or-string
in org-babel-ruby-evaluate needed?  It seems like org-babel-execute
already covers this processing.

--
Kyle

  reply	other threads:[~2015-08-11 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 20:52 fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby Matthew MacLean
2015-08-11 22:33 ` Kyle Meyer [this message]
2015-08-11 22:36   ` Kyle Meyer
2015-08-11 22:46     ` Matthew MacLean
2015-08-12  0:52       ` Kyle Meyer
2015-08-12  3:24         ` Matthew MacLean
2015-08-12  5:53           ` Kyle Meyer
2015-08-12  6:18             ` Matthew MacLean
2015-08-12 17:21               ` Kyle Meyer
2015-08-12 20:05                 ` Matthew MacLean
2015-08-13  3:41                   ` Kyle Meyer
2015-08-13  4:02                     ` Matthew MacLean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9o5316t.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=archenoth@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).