From: Eric Schulte <eric.schulte@gmx.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org Build System (aka Makefile)
Date: Mon, 13 Aug 2012 16:43:42 -0600 [thread overview]
Message-ID: <87ehna8lb5.fsf@gmx.com> (raw)
In-Reply-To: 877gt2oami.fsf@Rainer.invalid
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
Achim Gratz <Stromeko@nexgo.de> writes:
> Bastien writes:
>> However, I would suggest these changes to the current default.mk:
>
> These changes do not belong into default.mk — default.mk is the fallback
> for when no changes to local.mk have been made.
>
>> - Have a target `make single' (useful for developers)
>>
>> - `make elint' would run the current `make _COMPILE_=slint3'.
>
> I don't like such proliferation of toplevel targets since they can't be
> overridden by users,
I second the idea that a top level 'make elint' would be very useful for
developers (see the attached patch). In my opinion this would be more
useful than a number of existing top-level targets, e.g., config-*,
update, update2, cleanall, cleandirs, cleancontrib, cleantesting,
cleanutils, cleanelc and targets.
So if we want to have fewer top level targets (which I think would also
be a good idea), perhaps one or more of the above could be removed
before an elint target is added.
> things like this (an alias) are easy enough to set up in local.mk:
But many more people will use such a target if it exists at the top
level and is mentioned by "make help".
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-adding-elint-top-level-Makefile-target.patch --]
[-- Type: text/x-patch, Size: 1146 bytes --]
From 39e1ce6e8f33561db94451248d1c17705bd8f4ee Mon Sep 17 00:00:00 2001
From: Eric Schulte <eric.schulte@gmx.com>
Date: Mon, 13 Aug 2012 16:42:59 -0600
Subject: [PATCH] adding elint top-level Makefile target
---
Makefile | 1 +
targets.mk | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 71e2765..0b9535e 100644
--- a/Makefile
+++ b/Makefile
@@ -29,6 +29,7 @@ help helpall::
$(info make compile - build Org ELisp files)
$(info make autoloads - create org-install.el to load Org in-place)
$(info make check - build Org ELisp files and run test suite)
+ $(info make elint - perform a static check of ELisp source files)
helpall::
$(info make test - ditto)
$(info make compile-dirty - build only stale Org ELisp files)
diff --git a/targets.mk b/targets.mk
index 29b0aa5..7ddaff1 100644
--- a/targets.mk
+++ b/targets.mk
@@ -80,6 +80,9 @@ compile compile-dirty::
all clean-install::
$(foreach dir, $(SUBDIRS), $(MAKE) -C $(dir) $@;)
+elint:
+ $(MAKE) -b _COMPILE_=slint3
+
check test:: compile
check test test-dirty::
-$(MKDIR) $(testdir)
--
1.7.11.4
[-- Attachment #3: Type: text/plain, Size: 46 bytes --]
--
Eric Schulte
http://cs.unm.edu/~eschulte
next prev parent reply other threads:[~2012-08-13 22:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:37 Org Build System (aka Makefile) Achim Gratz
2012-07-15 21:38 ` Bastien
2012-08-09 17:03 ` Achim Gratz
2012-08-10 7:17 ` Bastien
2012-08-12 13:56 ` Achim Gratz
2012-08-12 18:56 ` Eric Schulte
2012-08-12 20:41 ` Achim Gratz
2012-08-13 13:16 ` Eric Schulte
2012-08-13 13:45 ` Bastien
2012-08-13 19:27 ` Achim Gratz
2012-08-13 22:43 ` Eric Schulte [this message]
2012-08-14 6:13 ` Achim Gratz
2012-08-14 12:46 ` Eric Schulte
2012-08-14 22:06 ` Bastien
2012-08-15 16:35 ` Achim Gratz
2012-08-14 22:45 ` Bastien
2012-08-15 17:55 ` Achim Gratz
2012-08-15 18:56 ` Bastien
2012-08-13 19:47 ` Achim Gratz
2012-08-14 22:07 ` Bastien
2012-08-12 22:27 ` Bastien
2012-08-13 6:11 ` Achim Gratz
2012-08-13 7:40 ` Bastien
2012-08-13 11:42 ` Achim Gratz
2012-08-13 13:13 ` Bastien
2012-08-13 14:17 ` Achim Gratz
2012-08-13 14:48 ` Bastien
2012-08-13 18:56 ` Achim Gratz
2012-08-13 5:34 ` Bastien
2012-08-12 16:58 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehna8lb5.fsf@gmx.com \
--to=eric.schulte@gmx.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).