* Scheme code evaluation in fresh Emacs
@ 2017-12-19 18:29 Neil Jerram
2017-12-19 19:30 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Neil Jerram @ 2017-12-19 18:29 UTC (permalink / raw)
To: org-mode mailing list
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
When I try to evaluate Scheme code in an Emacs where I haven't yet done
any Geiser/Scheme work, I get an error about
geiser-default-implementation being undefined. The attached patch fixes
that, but I am not sure if it is the most minimal fix possible. WDYT?
Best wishes - Neil
[-- Attachment #2: 0001-Fix-Scheme-evaluation-in-fresh-Emacs.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]
From adceb034b886d1c3624b31f83f8826869cd1b92c Mon Sep 17 00:00:00 2001
From: Neil Jerram <neil@tigera.io>
Date: Tue, 19 Dec 2017 18:15:00 +0000
Subject: [PATCH] Fix Scheme evaluation in fresh Emacs
* lisp/ob-scheme.el: Require geiser-impl so that
geiser-default-implementation is defined. Otherwise, unless Geiser
has previously been run (e.g. with `run-geiser'), you'll see an
error that geiser-default-implementation is undefined.
---
lisp/ob-scheme.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/ob-scheme.el b/lisp/ob-scheme.el
index f67080adf..7dbd78097 100644
--- a/lisp/ob-scheme.el
+++ b/lisp/ob-scheme.el
@@ -40,6 +40,7 @@
;;; Code:
(require 'ob)
(require 'geiser nil t)
+(require 'geiser-impl nil t)
(defvar geiser-repl--repl) ; Defined in geiser-repl.el
(defvar geiser-impl--implementation) ; Defined in geiser-impl.el
(defvar geiser-default-implementation) ; Defined in geiser-impl.el
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Scheme code evaluation in fresh Emacs
2017-12-19 18:29 Scheme code evaluation in fresh Emacs Neil Jerram
@ 2017-12-19 19:30 ` Nicolas Goaziou
2017-12-19 19:52 ` Neil Jerram
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2017-12-19 19:30 UTC (permalink / raw)
To: Neil Jerram; +Cc: org-mode mailing list
Hello,
Neil Jerram <neil@ossau.homelinux.net> writes:
> When I try to evaluate Scheme code in an Emacs where I haven't yet
> done any Geiser/Scheme work, I get an error about
> geiser-default-implementation being undefined. The attached patch
> fixes that, but I am not sure if it is the most minimal fix possible.
> WDYT?
Thank you. I applied the patch.
I think it would be worth notifying upstream about it, if you have some
spare time.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Scheme code evaluation in fresh Emacs
2017-12-19 19:30 ` Nicolas Goaziou
@ 2017-12-19 19:52 ` Neil Jerram
2017-12-19 21:49 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Neil Jerram @ 2017-12-19 19:52 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: org-mode mailing list
On 19/12/17 19:30, Nicolas Goaziou wrote:
> Hello,
>
> Neil Jerram <neil@ossau.homelinux.net> writes:
>
>> When I try to evaluate Scheme code in an Emacs where I haven't yet
>> done any Geiser/Scheme work, I get an error about
>> geiser-default-implementation being undefined. The attached patch
>> fixes that, but I am not sure if it is the most minimal fix possible.
>> WDYT?
> Thank you. I applied the patch.
>
> I think it would be worth notifying upstream about it, if you have some
> spare time.
Sure, but which upstream do you mean?
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Scheme code evaluation in fresh Emacs
2017-12-19 19:52 ` Neil Jerram
@ 2017-12-19 21:49 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2017-12-19 21:49 UTC (permalink / raw)
To: Neil Jerram; +Cc: org-mode mailing list
Neil Jerram <neil@ossau.homelinux.net> writes:
> On 19/12/17 19:30, Nicolas Goaziou wrote:
>> I think it would be worth notifying upstream about it, if you have some
>> spare time.
>
> Sure, but which upstream do you mean?
Geiser. Maybe geiser-default-implementation should autoload geiser-impl
or some such.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-19 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 18:29 Scheme code evaluation in fresh Emacs Neil Jerram
2017-12-19 19:30 ` Nicolas Goaziou
2017-12-19 19:52 ` Neil Jerram
2017-12-19 21:49 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).