emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Issue with org-fontify-done-headline
@ 2012-01-18 21:11 Brian J. Carlson
  2012-01-20 15:45 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Brian J. Carlson @ 2012-01-18 21:11 UTC (permalink / raw)
  To: emacs-orgmode


In the latest git version of org I've been having problems with
org-fontify-done-headline. 

After looking at (defun org-set-font-lock-defaults () I think there is a
problem with the following code.  

--8<---------------cut here---------------start------------->8---
	   ;; DONE
	   (if org-fontify-done-headline
	       (list (format org-heading-keyword-regexp-format
			     (concat
			      "\\("
			      (mapconcat 'regexp-quote org-done-keywords "\\|")
			      "\\)"))
		     '(2 'org-headline-done t))
	     nil)
--8<---------------cut here---------------end--------------->8---

I guess there are two ways to fix this: 

,----
| 	   (if org-fontify-done-headline
| 	       (list (format org-heading-keyword-regexp-format
| 			     (concat
| 			      "\\("
| 			      (mapconcat 'regexp-quote org-done-keywords "\\|")
| 			      "\\)"))
| 		     '(3 'org-headline-done t))
| 	     nil)
`----

or 

,----
| 	   (if org-fontify-done-headline
| 	       (list (format org-heading-keyword-regexp-format
| 			     (concat
| 			      "\\(?:"
| 			      (mapconcat 'regexp-quote org-done-keywords "\\|")
| 			      "\\)"))
| 		     '(2 'org-headline-done t))
| 	     nil)
`----

I have only gotten around to using "git clone", so I thought I'd post here
until I have a chance to learn how to issue a git push/pull request.  



-- 
Thanks,
;-b

Brian Carlson

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Issue with org-fontify-done-headline
  2012-01-18 21:11 Issue with org-fontify-done-headline Brian J. Carlson
@ 2012-01-20 15:45 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-01-20 15:45 UTC (permalink / raw)
  To: Brian J. Carlson; +Cc: emacs-orgmode

Hi Brian,

"Brian J. Carlson" <gmane.briancarlson@xoxy.net> writes:

> In the latest git version of org I've been having problems with
> org-fontify-done-headline. 

thanks for spotting this problem and for the suggested 
solution, it is now fixed.

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-20 15:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-18 21:11 Issue with org-fontify-done-headline Brian J. Carlson
2012-01-20 15:45 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).