emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Brian J. Carlson" <gmane.briancarlson@xoxy.net>
To: emacs-orgmode@gnu.org
Subject: Issue with org-fontify-done-headline
Date: Wed, 18 Jan 2012 16:11:02 -0500	[thread overview]
Message-ID: <87boq0af89.fsf@briancarlson.org> (raw)


In the latest git version of org I've been having problems with
org-fontify-done-headline. 

After looking at (defun org-set-font-lock-defaults () I think there is a
problem with the following code.  

--8<---------------cut here---------------start------------->8---
	   ;; DONE
	   (if org-fontify-done-headline
	       (list (format org-heading-keyword-regexp-format
			     (concat
			      "\\("
			      (mapconcat 'regexp-quote org-done-keywords "\\|")
			      "\\)"))
		     '(2 'org-headline-done t))
	     nil)
--8<---------------cut here---------------end--------------->8---

I guess there are two ways to fix this: 

,----
| 	   (if org-fontify-done-headline
| 	       (list (format org-heading-keyword-regexp-format
| 			     (concat
| 			      "\\("
| 			      (mapconcat 'regexp-quote org-done-keywords "\\|")
| 			      "\\)"))
| 		     '(3 'org-headline-done t))
| 	     nil)
`----

or 

,----
| 	   (if org-fontify-done-headline
| 	       (list (format org-heading-keyword-regexp-format
| 			     (concat
| 			      "\\(?:"
| 			      (mapconcat 'regexp-quote org-done-keywords "\\|")
| 			      "\\)"))
| 		     '(2 'org-headline-done t))
| 	     nil)
`----

I have only gotten around to using "git clone", so I thought I'd post here
until I have a chance to learn how to issue a git push/pull request.  



-- 
Thanks,
;-b

Brian Carlson

             reply	other threads:[~2012-01-18 22:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 21:11 Brian J. Carlson [this message]
2012-01-20 15:45 ` Issue with org-fontify-done-headline Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boq0af89.fsf@briancarlson.org \
    --to=gmane.briancarlson@xoxy.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).