emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* *Clock Task Select* - feature request
@ 2014-10-15 20:47 Marcin Borkowski
  2014-10-20 13:28 ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Marcin Borkowski @ 2014-10-15 20:47 UTC (permalink / raw)
  To: Org Mode List

Hi list,

I'd love it if *Clock Task Select* were buried (or better, killed) after
use.  (Is there ever a scenario when someone might want it not to be
killed?)  It seems that this should do:

================================================
*** /home/marcin/.emacs.d/elpa/org-20140116/org-clock.el
--- #<buffer org-clock.el>
***************
*** 559,564 ****
--- 559,565 ----
  	(fit-window-to-buffer nil nil (if (< chl 10) chl (+ 5 chl)))
  	(message (or prompt "Select task for clocking:"))
  	(setq cursor-type nil rpl (read-char-exclusive))
+ 	(kill-buffer)
  	(cond
  	 ((eq rpl ?q) nil)
  	 ((eq rpl ?x) nil)
***************
*** 975,980 ****
--- 976,982 ----
  			(read-char (concat (funcall prompt-fn clock)
  					   " [jkKgGSscCiq]? ")
  				   nil 45)))
+ 		(kill-buffer)
  		(and (not (memq char-pressed '(?i ?q))) char-pressed)))))
  	 (default
  	   (floor (/ (org-float-time
================================================

(the second addition should kill the buffer with the menu shown after
some idle time, though I didn't test it).

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Adam Mickiewicz University

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: *Clock Task Select* - feature request
  2014-10-15 20:47 *Clock Task Select* - feature request Marcin Borkowski
@ 2014-10-20 13:28 ` Bastien
  2014-10-20 13:50   ` Marcin Borkowski
  0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2014-10-20 13:28 UTC (permalink / raw)
  To: Marcin Borkowski; +Cc: Org Mode List

Hi Marcin,

Marcin Borkowski <mbork@wmi.amu.edu.pl> writes:

> I'd love it if *Clock Task Select* were buried (or better, killed) after
> use.  (Is there ever a scenario when someone might want it not to be
> killed?)  It seems that this should do:
>
> ================================================
> *** /home/marcin/.emacs.d/elpa/org-20140116/org-clock.el
> --- #<buffer org-clock.el>
> ***************
> *** 559,564 ****
> --- 559,565 ----
>   	(fit-window-to-buffer nil nil (if (< chl 10) chl (+ 5 chl)))
>   	(message (or prompt "Select task for clocking:"))
>   	(setq cursor-type nil rpl (read-char-exclusive))
> + 	(kill-buffer)
>   	(cond
>   	 ((eq rpl ?q) nil)
>   	 ((eq rpl ?x) nil)
> ***************
> *** 975,980 ****
> --- 976,982 ----
>   			(read-char (concat (funcall prompt-fn clock)
>   					   " [jkKgGSscCiq]? ")
>   				   nil 45)))
> + 		(kill-buffer)
>   		(and (not (memq char-pressed '(?i ?q))) char-pressed)))))
>   	 (default
>   	   (floor (/ (org-float-time
> ================================================
>
> (the second addition should kill the buffer with the menu shown after
> some idle time, though I didn't test it).

Good idea, I pushed this change.  I don't think the second kill-buffer
is necessary, as this buffer is already temporary.  Let me know if I'm
wrong.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: *Clock Task Select* - feature request
  2014-10-20 13:28 ` Bastien
@ 2014-10-20 13:50   ` Marcin Borkowski
  0 siblings, 0 replies; 3+ messages in thread
From: Marcin Borkowski @ 2014-10-20 13:50 UTC (permalink / raw)
  To: Org Mode List


On 2014-10-20, at 15:28, Bastien wrote:

> Hi Marcin,
>
> Good idea, I pushed this change.  I don't think the second kill-buffer
> is necessary, as this buffer is already temporary.  Let me know if I'm
> wrong.
>
> Thanks,

Thanks a lot - that was quite annoying for me!

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Adam Mickiewicz University

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-20 13:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-15 20:47 *Clock Task Select* - feature request Marcin Borkowski
2014-10-20 13:28 ` Bastien
2014-10-20 13:50   ` Marcin Borkowski

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).