emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Marcin Borkowski <mbork@wmi.amu.edu.pl>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: *Clock Task Select* - feature request
Date: Mon, 20 Oct 2014 15:28:30 +0200	[thread overview]
Message-ID: <87zjcqrhtt.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87y4shhxgt.fsf@wmi.amu.edu.pl> (Marcin Borkowski's message of "Wed, 15 Oct 2014 22:47:14 +0200")

Hi Marcin,

Marcin Borkowski <mbork@wmi.amu.edu.pl> writes:

> I'd love it if *Clock Task Select* were buried (or better, killed) after
> use.  (Is there ever a scenario when someone might want it not to be
> killed?)  It seems that this should do:
>
> ================================================
> *** /home/marcin/.emacs.d/elpa/org-20140116/org-clock.el
> --- #<buffer org-clock.el>
> ***************
> *** 559,564 ****
> --- 559,565 ----
>   	(fit-window-to-buffer nil nil (if (< chl 10) chl (+ 5 chl)))
>   	(message (or prompt "Select task for clocking:"))
>   	(setq cursor-type nil rpl (read-char-exclusive))
> + 	(kill-buffer)
>   	(cond
>   	 ((eq rpl ?q) nil)
>   	 ((eq rpl ?x) nil)
> ***************
> *** 975,980 ****
> --- 976,982 ----
>   			(read-char (concat (funcall prompt-fn clock)
>   					   " [jkKgGSscCiq]? ")
>   				   nil 45)))
> + 		(kill-buffer)
>   		(and (not (memq char-pressed '(?i ?q))) char-pressed)))))
>   	 (default
>   	   (floor (/ (org-float-time
> ================================================
>
> (the second addition should kill the buffer with the menu shown after
> some idle time, though I didn't test it).

Good idea, I pushed this change.  I don't think the second kill-buffer
is necessary, as this buffer is already temporary.  Let me know if I'm
wrong.

Thanks,

-- 
 Bastien

next prev parent reply	other threads:[~2014-10-20 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 20:47 *Clock Task Select* - feature request Marcin Borkowski
2014-10-20 13:28 ` Bastien [this message]
2014-10-20 13:50   ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjcqrhtt.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mbork@wmi.amu.edu.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).