emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [patch] small fix to org.texi
@ 2015-09-13 16:12 Joe Riel
  2015-09-13 16:25 ` Rasmus
  2015-09-13 17:30 ` [patch] small fix to org.texi add TINYCHANGE Joe Riel
  0 siblings, 2 replies; 7+ messages in thread
From: Joe Riel @ 2015-09-13 16:12 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

In "The export dispatcher", the phrase "from which it is possible to
select an export format and to toggle export options." is repeated.
This removes the duplication.



-- 
Joe Riel


[-- Attachment #2: 0003-doc-org.texi-The-export-dispatcher-elide-duplicate-p.patch --]
[-- Type: text/x-patch, Size: 1048 bytes --]

From b6319a36e57fdeb3318bcb02b2d76ba3e21e34c5 Mon Sep 17 00:00:00 2001
From: Joe Riel <jriel@maplesoft.com>
Date: Sat, 12 Sep 2015 14:23:42 -0700
Subject: [PATCH 3/3] * doc/org.texi: (The export dispatcher): elide duplicate
 phrase

The phrase "from which it is possible to select an export format and to toggle
export options." appeared both before and after the footnote.
---
 doc/org.texi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/org.texi b/doc/org.texi
index c630c7a..8de8efc 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -10600,8 +10600,7 @@ toggle export options@footnote{It is also possible to use a less intrusive
 interface by setting @code{org-export-dispatch-use-expert-ui} to a
 non-@code{nil} value.  In that case, only a prompt is visible from the
 minibuffer.  From there one can still switch back to regular menu by pressing
-@key{?}.} from which it is possible to select an export format and to toggle
-export options.
+@key{?}.}.
 
 @table @asis
 @orgcmd{C-c C-e,org-export-dispatch}
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi
  2015-09-13 16:12 [patch] small fix to org.texi Joe Riel
@ 2015-09-13 16:25 ` Rasmus
  2015-09-13 16:29   ` Joe Riel
  2015-09-13 17:30 ` [patch] small fix to org.texi add TINYCHANGE Joe Riel
  1 sibling, 1 reply; 7+ messages in thread
From: Rasmus @ 2015-09-13 16:25 UTC (permalink / raw)
  To: emacs-orgmode

Joe Riel <joer@san.rr.com> writes:

> In "The export dispatcher", the phrase "from which it is possible to
> select an export format and to toggle export options." is repeated.
> This removes the duplication.

Thanks.

I think you need to add a TINYCHANGE cookie to the commit message unless
you have a copyright assignment to FSF.  See

    http://orgmode.org/worg/org-contribute.html#orgheadline6

Rasmus

-- 
ツ

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi
  2015-09-13 16:25 ` Rasmus
@ 2015-09-13 16:29   ` Joe Riel
  2015-09-13 16:40     ` Rasmus
  0 siblings, 1 reply; 7+ messages in thread
From: Joe Riel @ 2015-09-13 16:29 UTC (permalink / raw)
  To: Rasmus; +Cc: emacs-orgmode

On Sun, 13 Sep 2015 18:25:12 +0200
Rasmus <rasmus@gmx.us> wrote:

> Joe Riel <joer@san.rr.com> writes:
> 
> > In "The export dispatcher", the phrase "from which it is possible to
> > select an export format and to toggle export options." is repeated.
> > This removes the duplication.
> 
> Thanks.
> 
> I think you need to add a TINYCHANGE cookie to the commit message unless
> you have a copyright assignment to FSF.  See
> 
>     http://orgmode.org/worg/org-contribute.html#orgheadline6
> 
> Rasmus
> 

Thanks for the notice. 

I didn't see that when I first read it.  Hmm.  I posted two others
yesterday.  What should I do now?  Edit the commit messages and
post the patches?  Would the duplicate posts be an issue?

-- 
Joe Riel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi
  2015-09-13 16:29   ` Joe Riel
@ 2015-09-13 16:40     ` Rasmus
  2015-09-13 17:34       ` Joe Riel
  0 siblings, 1 reply; 7+ messages in thread
From: Rasmus @ 2015-09-13 16:40 UTC (permalink / raw)
  To: emacs-orgmode

Joe Riel <joer@san.rr.com> writes:

> Thanks for the notice. 
>
> I didn't see that when I first read it.  Hmm.  I posted two others
> yesterday.  What should I do now?  Edit the commit messages and
> post the patches?  Would the duplicate posts be an issue?

Thanks, I hadn't seen those patches.  Just reply to the mail with the
patches and attach the patch with updated commit message.

Since your git email suggests that you are associated with a major
software company, it's best if we follow the rules stringently.

Also, I believe there's a limit of 10 lines you can change without
copyright assignment.  Though you have only changed documentation, which
may or may not be within the same limit....  Anyway, it's not an issue
presently.  Hopefully somebody knows to what extend there's a difference
between documentation and code, if at all.

Thanks for the patches and sorry to be a bother.

Rasmus

-- 
One thing that is clear: it's all down hill from here 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi add TINYCHANGE
  2015-09-13 16:12 [patch] small fix to org.texi Joe Riel
  2015-09-13 16:25 ` Rasmus
@ 2015-09-13 17:30 ` Joe Riel
  2015-09-13 18:25   ` Rasmus
  1 sibling, 1 reply; 7+ messages in thread
From: Joe Riel @ 2015-09-13 17:30 UTC (permalink / raw)
  To: Joe Riel; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On Sun, 13 Sep 2015 09:12:37 -0700
Joe Riel <joer@san.rr.com> wrote:

> In "The export dispatcher", the phrase "from which it is possible to
> select an export format and to toggle export options." is repeated.
> This removes the duplication.

The attached adds TINYCHANGE to the commit message.


-- 
Joe Riel


[-- Attachment #2: 0003-doc-org.texi-elide-duplicate-phrase.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]

From 5fd27a2ec60b5199d711995ca0ed5e9810a658e4 Mon Sep 17 00:00:00 2001
From: Joe Riel <jriel@maplesoft.com>
Date: Sat, 12 Sep 2015 14:23:42 -0700
Subject: [PATCH 3/3] doc/org.texi: elide duplicate phrase

* doc/org.texi (The export dispatcher):

The phrase "from which it is possible to select an export format and to toggle
export options." appeared both before and after the footnote.  Remove the
redundancy.

TINYCHANGE.
---
 doc/org.texi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/org.texi b/doc/org.texi
index c630c7a..8de8efc 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -10600,8 +10600,7 @@ toggle export options@footnote{It is also possible to use a less intrusive
 interface by setting @code{org-export-dispatch-use-expert-ui} to a
 non-@code{nil} value.  In that case, only a prompt is visible from the
 minibuffer.  From there one can still switch back to regular menu by pressing
-@key{?}.} from which it is possible to select an export format and to toggle
-export options.
+@key{?}.}.
 
 @table @asis
 @orgcmd{C-c C-e,org-export-dispatch}
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi
  2015-09-13 16:40     ` Rasmus
@ 2015-09-13 17:34       ` Joe Riel
  0 siblings, 0 replies; 7+ messages in thread
From: Joe Riel @ 2015-09-13 17:34 UTC (permalink / raw)
  To: Rasmus; +Cc: emacs-orgmode

On Sun, 13 Sep 2015 18:40:12 +0200
Rasmus <rasmus@gmx.us> wrote:

> Joe Riel <joer@san.rr.com> writes:
> 
> > Thanks for the notice. 
> >
> > I didn't see that when I first read it.  Hmm.  I posted two others
> > yesterday.  What should I do now?  Edit the commit messages and
> > post the patches?  Would the duplicate posts be an issue?
> 
> Thanks, I hadn't seen those patches.  Just reply to the mail with the
> patches and attach the patch with updated commit message.
> 
> Since your git email suggests that you are associated with a major
> software company, it's best if we follow the rules stringently.
> 
> Also, I believe there's a limit of 10 lines you can change without
> copyright assignment.  Though you have only changed documentation, which
> may or may not be within the same limit....  Anyway, it's not an issue
> presently.  Hopefully somebody knows to what extend there's a difference
> between documentation and code, if at all.
> 
> Thanks for the patches and sorry to be a bother.

No problem.  I modified the commit messages.
Also sent an email to assign copyright to FSF.


-- 
Joe Riel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch] small fix to org.texi add TINYCHANGE
  2015-09-13 17:30 ` [patch] small fix to org.texi add TINYCHANGE Joe Riel
@ 2015-09-13 18:25   ` Rasmus
  0 siblings, 0 replies; 7+ messages in thread
From: Rasmus @ 2015-09-13 18:25 UTC (permalink / raw)
  To: emacs-orgmode

Joe Riel <joer@san.rr.com> writes:

> On Sun, 13 Sep 2015 09:12:37 -0700
> Joe Riel <joer@san.rr.com> wrote:
>
>> In "The export dispatcher", the phrase "from which it is possible to
>> select an export format and to toggle export options." is repeated.
>> This removes the duplication.
>
> The attached adds TINYCHANGE to the commit message.

Pushed thanks.

In general you don't have to write to long changelog entries.  You can
write it in the accompanying email if you want.

Also, the format is

     * file-changed.el (node/function): Capitalized and a period.

No line break and capitalized and finish with period.

I changed some minor things in the patches.

Thanks again.

Rasmus

-- 
When in doubt, do it!

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-09-13 18:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-13 16:12 [patch] small fix to org.texi Joe Riel
2015-09-13 16:25 ` Rasmus
2015-09-13 16:29   ` Joe Riel
2015-09-13 16:40     ` Rasmus
2015-09-13 17:34       ` Joe Riel
2015-09-13 17:30 ` [patch] small fix to org.texi add TINYCHANGE Joe Riel
2015-09-13 18:25   ` Rasmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).