From: No Wayman <iarchivedmywholelife@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)]
Date: Fri, 20 Jan 2023 12:34:08 -0500 [thread overview]
Message-ID: <87bkmtjebj.fsf@gmail.com> (raw)
In-Reply-To: <877cxhs7dh.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
>> Feel free to take this the patch as a base to do whatever you
>> please with it.
>
> Then, I am thinking about a simple approach that will not
> involve
> internet connection. See the attached.
I think that's the best solution. I landed on something similar
for Elpaca (and will likely suggest the same for straight.el).
> Note that you, in fact, can fetch the latest tags from remote
> into
> shallow clone. See
> https://stackoverflow.com/questions/66349002/get-latest-tag-git-describe-tags-when-repo-is-cloned-with-depth-1
Seems more complicated than it's worth at this point.
> # Use the org.el header.
> ORGVERSION := $(patsubst %-dev,%,$(shell $(BATCH) --eval
> "(require 'lisp-mnt)" \
> --visit lisp/org.el --eval '(princ (lm-header
> "version"))'))
> - GITVERSION ?= $(shell git describe --match release\*
> --abbrev=6 HEAD)
> + GITVERSION ?= $(shell git describe --match release\*
> --abbrev=6 HEAD 2>/dev/null || echo "release_N/A-N/A-$(shell
> git log --format=%h HEAD^..HEAD)")
Why not use ORGVERSION here? Is the metadata in org.el's version
header not updated when a commit is tagged as a release?
next prev parent reply other threads:[~2023-01-20 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 20:01 [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] No Wayman
2023-01-15 20:55 ` No Wayman
2023-01-16 13:38 ` Ihor Radchenko
2023-01-16 19:11 ` No Wayman
2023-01-17 10:38 ` Ihor Radchenko
2023-01-18 23:11 ` No Wayman
2023-01-18 23:12 ` No Wayman
2023-01-19 11:19 ` Ihor Radchenko
2023-01-20 1:38 ` No Wayman
2023-01-20 12:44 ` Ihor Radchenko
2023-01-20 14:50 ` Max Nikulin
2023-02-10 13:21 ` Ihor Radchenko
2023-01-20 17:34 ` No Wayman [this message]
2023-01-21 9:36 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkmtjebj.fsf@gmail.com \
--to=iarchivedmywholelife@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).