From: Max Nikulin <manikulin@gmail.com>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)]
Date: Fri, 20 Jan 2023 21:50:50 +0700 [thread overview]
Message-ID: <236849a2-144c-8f9e-a735-3af87582d4ec@gmail.com> (raw)
In-Reply-To: <877cxhs7dh.fsf@localhost>
On 20/01/2023 19:44, Ihor Radchenko wrote:
> diff --git a/mk/targets.mk b/mk/targets.mk
> index 4435daa..164b092 100644
> --- a/mk/targets.mk
> +++ b/mk/targets.mk
> @@ -14,7 +14,7 @@ ifneq ($(wildcard .git),)
> # Use the org.el header.
> ORGVERSION := $(patsubst %-dev,%,$(shell $(BATCH) --eval "(require 'lisp-mnt)" \
> --visit lisp/org.el --eval '(princ (lm-header "version"))'))
> - GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD)
> + GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD 2>/dev/null || echo "release_N/A-N/A-$(shell git log --format=%h
another option is to use --always
git describe --match release\* --abbrev=6 --always HEAD
52f29d
and some make code that prepends it with release_$(ORGVERSION)- if it
has not release prefix.
Earlier posted patches attempts to make remote query even if history
depth of local copy is enough to include a commit tagged as release. I
have found some recipes how to modify "git fetch" to get enough objects
for "git describe", but I have never used them, so unsure concerning
their reliability. Perhaps they may be used in CI configuration, namely
in the script preparing source directory, since fetch is not
responsibility of make.
next prev parent reply other threads:[~2023-01-20 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 20:01 [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] No Wayman
2023-01-15 20:55 ` No Wayman
2023-01-16 13:38 ` Ihor Radchenko
2023-01-16 19:11 ` No Wayman
2023-01-17 10:38 ` Ihor Radchenko
2023-01-18 23:11 ` No Wayman
2023-01-18 23:12 ` No Wayman
2023-01-19 11:19 ` Ihor Radchenko
2023-01-20 1:38 ` No Wayman
2023-01-20 12:44 ` Ihor Radchenko
2023-01-20 14:50 ` Max Nikulin [this message]
2023-02-10 13:21 ` Ihor Radchenko
2023-01-20 17:34 ` No Wayman
2023-01-21 9:36 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236849a2-144c-8f9e-a735-3af87582d4ec@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).