From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qOXWLG7RymP3sQAAbAwnHQ (envelope-from ) for ; Fri, 20 Jan 2023 18:37:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2E7ZLG7RymOBbAEAauVa8A (envelope-from ) for ; Fri, 20 Jan 2023 18:37:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03A031137C for ; Fri, 20 Jan 2023 18:37:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIvK5-00052V-Bh; Fri, 20 Jan 2023 12:37:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIvJu-0004zK-Bj for emacs-orgmode@gnu.org; Fri, 20 Jan 2023 12:36:54 -0500 Received: from mail-vk1-xa29.google.com ([2607:f8b0:4864:20::a29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIvJs-00009a-Lq for emacs-orgmode@gnu.org; Fri, 20 Jan 2023 12:36:54 -0500 Received: by mail-vk1-xa29.google.com with SMTP id 12so2869222vkj.12 for ; Fri, 20 Jan 2023 09:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=1TDvz7kbmtlhLaO7IJ06EmIfaT0IFb9Mn5k/Ha/nLAc=; b=X23OqguOuZyFg0QWak/wS82lNqJexpF3+2Xry2PfjlfVJW+ffstkQJ4ovB/6KxX2xF GkvmhDdEOFljJPKi/CMa44ZmBfUwwgeCa6C4na28KzM6wGjCzgvod7Ii87tMkLiJUUx3 bECO86DQL8Y6eycH07h3Kkpdfwlx6m4UMIqI55TwaW/g5KZPPMXT5qpyW8sx1QlfOOxj 76QTGT0gBOfVD8hYYdN1Q8FhaxqYCfzzzb83xNTQiOO53lS9wqHYrJ95T8j66JpED9WD C8BD2uU3O4AGVqSkgcF1m2EHi3rF5IlDc9Da/c3kOnSIGff82DW3J1bQDw6ufdnbeBub NWPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1TDvz7kbmtlhLaO7IJ06EmIfaT0IFb9Mn5k/Ha/nLAc=; b=zMOlPtj8oRZx8R5Xq5YSnH7hCrWyF+FswUj5wGc3BRljxnG9dB2BclCUS04V27f6EK s5S2MgVaIc+VkxrW21qHE424gR+vO3t2R2SeFE/pSEYKCBEvIby27B5ZEcIveZf3t9uO KwsJR8hSLpdtUWI3azRh94yOwyivWmcPw0jFDtRAQGiyj5cB+bEu3cSO0CIYoyxYrWxJ NV/RSDUyNWWZ6tSVE+UFIOpMrbbU2jZUEuabMf7tjHU6gzkuJcI9qogOpXvnPHfFm0L1 8P9M/DtxjYX+Rk/iW8mjJptupxWAAYOXc+Y/AOFlsVFA0VompQcfWYPlQdT5tTYI4QCI nqsA== X-Gm-Message-State: AFqh2kqzw+BFieQDuyqKQOrsmk1XXPRbunTjNmDjzrkTXbpslkvHLnqg gCINBGr2ZkCbD4MkCqWtLwSU4DDG8WM= X-Google-Smtp-Source: AMrXdXuUgDyZHZZOorknH2Vb33XcQZ4VGBgYFAZMP+ynpfhNrAc4k/SPiPV9LKTUPo7xaIVFCJHOGA== X-Received: by 2002:a1f:2796:0:b0:3df:d8a5:ab51 with SMTP id n144-20020a1f2796000000b003dfd8a5ab51mr9495176vkn.16.1674236208035; Fri, 20 Jan 2023 09:36:48 -0800 (PST) Received: from nbook ([2601:82:c200:166d:7a0:14e6:e26:75bd]) by smtp.gmail.com with ESMTPSA id k19-20020a05620a415300b006fbaf9c1b70sm11398747qko.133.2023.01.20.09.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 09:36:47 -0800 (PST) References: <87r0vvr2ai.fsf@gmail.com> <87358alhux.fsf@localhost> <87tu0q5m2t.fsf@gmail.com> <877cxligy6.fsf@localhost> <87fsc7e8ub.fsf@gmail.com> <87bkmve8qv.fsf@gmail.com> <87bkmu4vqg.fsf@localhost> <87wn5it214.fsf@gmail.com> <877cxhs7dh.fsf@localhost> User-agent: mu4e 1.9.14; emacs 30.0.50 From: No Wayman To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] Date: Fri, 20 Jan 2023 12:34:08 -0500 In-reply-to: <877cxhs7dh.fsf@localhost> Message-ID: <87bkmtjebj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::a29; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-vk1-xa29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674236270; a=rsa-sha256; cv=none; b=R9hTy2rLxKeDaps9ioaUWCjVfQ49CZMu0s6C6UTS+vst1F7UobjLBZ5ntDbTfOHaTV7oSc Yj7GIK2hNE2nSMP6Z/aDSHVwxSuKLhK7u7z2eclKoY3jM63fgIZfrG/+KfzBmVqkR5MfpG Y4XqRXRdJOdRcHQGw+2OcHttJg100jLzXr46WP4Ff0/Xxs9niYpvgW05a2Bkm8eIYeSE9q 3KhxQmENzhc4hts9IA3++CsMBuzSqxQNhbRwOjMCgtCKM10usi0u8DfHk+9T869eVNrxfD 1wx8Hfvy3aYh7c23kzwsgJRhwqV60NUOMoRWB1nGAxNzYeDcoyQEeq7cGDxuxQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X23OqguO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674236270; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1TDvz7kbmtlhLaO7IJ06EmIfaT0IFb9Mn5k/Ha/nLAc=; b=f7Sy30GnA8sNpIpUP8v16p520JfwVRYOlFTlmjBXgfRlctQmpzhH9bYytlkYumT3rso69e OVlR7DfR/7olqq+yFUPP2WCy6YnR1MuUA2PO1b0Q7wTFo3q7EeNdcAA323WY93EH8fwNB4 yajIb7fwTD8bjrFNt3kbkBCfgb6TJA9ZV1d8ojX44egdJ0FylG9hgGbsZiKLo9v9F3ekT7 4Mswh0NJ8L7YblHh+OvHwuAFhWQTtNdjdEBCqO59BsKs4SkKQeMB/0LEm40NK7c/3b9ub0 ZSlnDosHxBZcMeMDPnJzj+yF1dUk8OoB/iIPblg6dnxBsqAp+lsurEYheI2pFA== X-Spam-Score: -9.58 X-Migadu-Queue-Id: 03A031137C Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X23OqguO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -9.58 X-TUID: Dr6BWfiX0CUh Ihor Radchenko writes: > No Wayman writes: > >> Feel free to take this the patch as a base to do whatever you >> please with it. > > Then, I am thinking about a simple approach that will not > involve > internet connection. See the attached. I think that's the best solution. I landed on something similar for Elpaca (and will likely suggest the same for straight.el). > Note that you, in fact, can fetch the latest tags from remote > into > shallow clone. See > https://stackoverflow.com/questions/66349002/get-latest-tag-git-describe-tags-when-repo-is-cloned-with-depth-1 Seems more complicated than it's worth at this point. > # Use the org.el header. > ORGVERSION := $(patsubst %-dev,%,$(shell $(BATCH) --eval > "(require 'lisp-mnt)" \ > --visit lisp/org.el --eval '(princ (lm-header > "version"))')) > - GITVERSION ?= $(shell git describe --match release\* > --abbrev=6 HEAD) > + GITVERSION ?= $(shell git describe --match release\* > --abbrev=6 HEAD 2>/dev/null || echo "release_N/A-N/A-$(shell > git log --format=%h HEAD^..HEAD)") Why not use ORGVERSION here? Is the metadata in org.el's version header not updated when a commit is tagged as a release?