* 7.01trans obsolete variables
@ 2010-09-07 20:16 Achim Gratz
2010-09-07 22:12 ` Noorul Islam
0 siblings, 1 reply; 5+ messages in thread
From: Achim Gratz @ 2010-09-07 20:16 UTC (permalink / raw)
To: emacs-orgmode
These warnings have been appearing for a while now:
In org-order-calendar-date-args:
org.el:14592:31:Warning: `european-calendar-style' is an obsolete variable (as
of Emacs 23.1); use `calendar-date-style' instead.
Wrote /root/emacs/org-mode/lisp/org.elc
In org-agenda-add-entry-to-org-agenda-diary-file:
org-agenda.el:7282:42:Warning: `european-calendar-style' is an obsolete
variable (as of Emacs 23.1); use `calendar-date-style' instead.
Wrote /root/emacs/org-mode/lisp/org-agenda.elc
Can't they be changed because of backwards compatibility?
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Waldorf MIDI Implementation & additional documentation:
http://Synth.Stromeko.net/Downloads.html#WaldorfDocs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 7.01trans obsolete variables
2010-09-07 20:16 7.01trans obsolete variables Achim Gratz
@ 2010-09-07 22:12 ` Noorul Islam
2010-09-08 16:07 ` Achim Gratz
0 siblings, 1 reply; 5+ messages in thread
From: Noorul Islam @ 2010-09-07 22:12 UTC (permalink / raw)
To: Achim Gratz; +Cc: emacs-orgmode
On Wed, Sep 8, 2010 at 1:46 AM, Achim Gratz <Stromeko@nexgo.de> wrote:
>
> These warnings have been appearing for a while now:
>
> In org-order-calendar-date-args:
> org.el:14592:31:Warning: `european-calendar-style' is an obsolete variable (as
> of Emacs 23.1); use `calendar-date-style' instead.
> Wrote /root/emacs/org-mode/lisp/org.elc
>
> In org-agenda-add-entry-to-org-agenda-diary-file:
> org-agenda.el:7282:42:Warning: `european-calendar-style' is an obsolete
> variable (as of Emacs 23.1); use `calendar-date-style' instead.
> Wrote /root/emacs/org-mode/lisp/org-agenda.elc
>
> Can't they be changed because of backwards compatibility?
I think these cannot be changed because `calendar-date-style' is not
available on earlier version of Emacs.
Thanks and Regards
Noorul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 7.01trans obsolete variables
2010-09-07 22:12 ` Noorul Islam
@ 2010-09-08 16:07 ` Achim Gratz
2010-09-13 18:25 ` [PATCH] silence byte compiler warnings about european-calendar-style Achim Gratz
0 siblings, 1 reply; 5+ messages in thread
From: Achim Gratz @ 2010-09-08 16:07 UTC (permalink / raw)
To: emacs-orgmode
Noorul Islam <noorul@noorul.com> writes:
> I think these cannot be changed because `calendar-date-style' is not
> available on earlier version of Emacs.
I was thinking that maybe a defvaralias only for EMACSen earlier than 23.1
might be a better solution that both keeps the compiler happy and the
code uncluttered (in one of the files a comment hints at the situation,
in the other there is none).
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] silence byte compiler warnings about european-calendar-style
2010-09-08 16:07 ` Achim Gratz
@ 2010-09-13 18:25 ` Achim Gratz
2010-09-14 7:31 ` [Accepted] " Carsten Dominik
0 siblings, 1 reply; 5+ messages in thread
From: Achim Gratz @ 2010-09-13 18:25 UTC (permalink / raw)
To: emacs-orgmode
I've investigated further and defvaralias doesn't silence the warnings,
but "with-no-warnings" does.
---
lisp/org-agenda.el | 3 ++-
lisp/org.el | 7 ++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 32c65db..9f94fa6 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7279,7 +7279,8 @@ the resulting entry will not be shown. When TEXT is empty, switch to
(let ((calendar-date-display-form
(if (if (boundp 'calendar-date-style)
(eq calendar-date-style 'european)
- (org-bound-and-true-p european-calendar-style)) ; Emacs 22
+ (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
+ (org-bound-and-true-p european-calendar-style))) ; Emacs 22
'(day " " month " " year)
'(month " " day " " year))))
diff --git a/lisp/org.el b/lisp/org.el
index 668d469..70dd482 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14604,9 +14604,10 @@ user function argument order change dependent on argument order."
(list arg2 arg1 arg3))
((eq calendar-date-style 'iso)
(list arg2 arg3 arg1)))
- (if (org-bound-and-true-p european-calendar-style)
- (list arg2 arg1 arg3)
- (list arg1 arg2 arg3))))
+ (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
+ (if (org-bound-and-true-p european-calendar-style)
+ (list arg2 arg1 arg3)
+ (list arg1 arg2 arg3)))))
(defun org-eval-in-calendar (form &optional keepdate)
"Eval FORM in the calendar window and return to current window.
--
1.7.1
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf Blofeld V1.15B11:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Accepted] silence byte compiler warnings about european-calendar-style
2010-09-13 18:25 ` [PATCH] silence byte compiler warnings about european-calendar-style Achim Gratz
@ 2010-09-14 7:31 ` Carsten Dominik
0 siblings, 0 replies; 5+ messages in thread
From: Carsten Dominik @ 2010-09-14 7:31 UTC (permalink / raw)
To: emacs-orgmode
Patch 272 (http://patchwork.newartisans.com/patch/272/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C87aanlzejg.fsf_-_%40Rainer.invalid%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] silence byte compiler warnings about european-calendar-style
> Date: Mon, 13 Sep 2010 23:25:39 -0000
> From: Achim Gratz <Stromeko@nexgo.de>
> X-Patchwork-Id: 272
> Message-Id: <87aanlzejg.fsf_-_@Rainer.invalid>
> To: emacs-orgmode@gnu.org
>
> I've investigated further and defvaralias doesn't silence the warnings,
> but "with-no-warnings" does.
>
> ---
> lisp/org-agenda.el | 3 ++-
> lisp/org.el | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 32c65db..9f94fa6 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7279,7 +7279,8 @@ the resulting entry will not be shown. When TEXT is empty, switch to
> (let ((calendar-date-display-form
> (if (if (boundp 'calendar-date-style)
> (eq calendar-date-style 'european)
> - (org-bound-and-true-p european-calendar-style)) ; Emacs 22
> + (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
> + (org-bound-and-true-p european-calendar-style))) ; Emacs 22
> '(day " " month " " year)
> '(month " " day " " year))))
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 668d469..70dd482 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14604,9 +14604,10 @@ user function argument order change dependent on argument order."
> (list arg2 arg1 arg3))
> ((eq calendar-date-style 'iso)
> (list arg2 arg3 arg1)))
> - (if (org-bound-and-true-p european-calendar-style)
> - (list arg2 arg1 arg3)
> - (list arg1 arg2 arg3))))
> + (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
> + (if (org-bound-and-true-p european-calendar-style)
> + (list arg2 arg1 arg3)
> + (list arg1 arg2 arg3)))))
>
> (defun org-eval-in-calendar (form &optional keepdate)
> "Eval FORM in the calendar window and return to current window.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-14 7:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-07 20:16 7.01trans obsolete variables Achim Gratz
2010-09-07 22:12 ` Noorul Islam
2010-09-08 16:07 ` Achim Gratz
2010-09-13 18:25 ` [PATCH] silence byte compiler warnings about european-calendar-style Achim Gratz
2010-09-14 7:31 ` [Accepted] " Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).