From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] silence byte compiler warnings about european-calendar-style
Date: Tue, 14 Sep 2010 09:31:29 +0200 (CEST) [thread overview]
Message-ID: <20100914073129.C788D74D757@u016822.science.uva.nl> (raw)
In-Reply-To: 87aanlzejg.fsf_-_@Rainer.invalid
Patch 272 (http://patchwork.newartisans.com/patch/272/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C87aanlzejg.fsf_-_%40Rainer.invalid%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] silence byte compiler warnings about european-calendar-style
> Date: Mon, 13 Sep 2010 23:25:39 -0000
> From: Achim Gratz <Stromeko@nexgo.de>
> X-Patchwork-Id: 272
> Message-Id: <87aanlzejg.fsf_-_@Rainer.invalid>
> To: emacs-orgmode@gnu.org
>
> I've investigated further and defvaralias doesn't silence the warnings,
> but "with-no-warnings" does.
>
> ---
> lisp/org-agenda.el | 3 ++-
> lisp/org.el | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 32c65db..9f94fa6 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7279,7 +7279,8 @@ the resulting entry will not be shown. When TEXT is empty, switch to
> (let ((calendar-date-display-form
> (if (if (boundp 'calendar-date-style)
> (eq calendar-date-style 'european)
> - (org-bound-and-true-p european-calendar-style)) ; Emacs 22
> + (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
> + (org-bound-and-true-p european-calendar-style))) ; Emacs 22
> '(day " " month " " year)
> '(month " " day " " year))))
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 668d469..70dd482 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14604,9 +14604,10 @@ user function argument order change dependent on argument order."
> (list arg2 arg1 arg3))
> ((eq calendar-date-style 'iso)
> (list arg2 arg3 arg1)))
> - (if (org-bound-and-true-p european-calendar-style)
> - (list arg2 arg1 arg3)
> - (list arg1 arg2 arg3))))
> + (with-no-warnings ;; european-calendar-style is obsolete as of version 23.1
> + (if (org-bound-and-true-p european-calendar-style)
> + (list arg2 arg1 arg3)
> + (list arg1 arg2 arg3)))))
>
> (defun org-eval-in-calendar (form &optional keepdate)
> "Eval FORM in the calendar window and return to current window.
>
prev parent reply other threads:[~2010-09-14 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 20:16 7.01trans obsolete variables Achim Gratz
2010-09-07 22:12 ` Noorul Islam
2010-09-08 16:07 ` Achim Gratz
2010-09-13 18:25 ` [PATCH] silence byte compiler warnings about european-calendar-style Achim Gratz
2010-09-14 7:31 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914073129.C788D74D757@u016822.science.uva.nl \
--to=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).