From: Eric Schulte <eric.schulte@gmx.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Temp files from testing are permanent...
Date: Sat, 18 Feb 2012 10:46:35 -0700 [thread overview]
Message-ID: <87aa4gqbk4.fsf@gmx.com> (raw)
In-Reply-To: <87sjiay7aq.fsf@Rainer.invalid> (Achim Gratz's message of "Thu, 16 Feb 2012 19:14:37 +0100")
Achim Gratz <Stromeko@nexgo.de> writes:
> Olaf Meeuwissen <olaf.meeuwissen@avasys.jp> writes:
>> Successful tests can clean up after themselves but failed tests should
>> not so you can debug. The decision to remove these files should be left
>> to whoever runs the test suite. That implies that even successful tests
>> don't really have to bother cleaning up after themselves.
>
> As hinted at in another post yesterday, I did browse the test suite code
> briefly. The tests try to clean up after themselves, sort-of
Sorry to come late to this discussion. The tests should clean up all
temporary files and buffers left during their execution. There has been
some work on this in the last month or two so hopefully the situation
has improved.
> — the trouble is that they leave tangled files and results produced
> during suceesful tests.
>
It will be up to the authors of individual tests to remove tangled and
exported files. Ideally we can patch each test to clean up after
itself. Perhaps we should provide a test macro which accepts a list of
file names and optionally removes them if the test exists successfully.
e.g.,
(org-test-with-cleanup '("exported.html" "tangled.sh" etc...)
...test body...)
>
>> If you use `make check` to run the test suite, you can easily set TMPDIR
>> via the TESTS_ENVIRONMENT Makefile variable (assuming that that variable
>> is taken into account when making unique file names). Something like
>
> Yes, that's about the same conclusion I also reached. Not sure when
> I'll have time to implement and test it.
>
Even if the above is implemented this sounds like a good safeguard.
Thanks,
>
>
> Regards,
> Achim.
--
Eric Schulte
http://cs.unm.edu/~eschulte/
next prev parent reply other threads:[~2012-02-18 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 18:31 Temp files from testing are permanent Achim Gratz
2012-02-14 23:12 ` Olaf Meeuwissen
2012-02-15 17:11 ` Achim Gratz
2012-02-15 18:02 ` Brian Wightman
2012-02-15 18:38 ` Achim Gratz
2012-02-16 20:47 ` Achim Gratz
2012-02-16 0:54 ` Olaf Meeuwissen
2012-02-16 18:14 ` Achim Gratz
2012-02-18 17:46 ` Eric Schulte [this message]
2012-02-18 18:48 ` Achim Gratz
2012-02-19 16:21 ` Eric Schulte
2012-02-19 17:03 ` Achim Gratz
2012-02-20 0:11 ` Olaf Meeuwissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa4gqbk4.fsf@gmx.com \
--to=eric.schulte@gmx.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).