From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Temp files from testing are permanent... Date: Sat, 18 Feb 2012 10:46:35 -0700 Message-ID: <87aa4gqbk4.fsf@gmx.com> References: <8762f9w9l3.fsf@Rainer.invalid> <87sjidovpo.fsf@avasys.jp> <877gzof2e1.fsf@Rainer.invalid> <8762f7d2dp.fsf@avasys.jp> <87sjiay7aq.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:40052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyoMx-0005PN-Sx for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 12:46:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyoMv-0004k7-Vt for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 12:46:47 -0500 Received: from mailout-us.gmx.com ([74.208.5.67]:53186 helo=mailout-us.mail.com) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RyoMv-0004jq-KB for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 12:46:45 -0500 In-Reply-To: <87sjiay7aq.fsf@Rainer.invalid> (Achim Gratz's message of "Thu, 16 Feb 2012 19:14:37 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Olaf Meeuwissen writes: >> Successful tests can clean up after themselves but failed tests should >> not so you can debug. The decision to remove these files should be left >> to whoever runs the test suite. That implies that even successful tests >> don't really have to bother cleaning up after themselves. > > As hinted at in another post yesterday, I did browse the test suite code > briefly. The tests try to clean up after themselves, sort-of Sorry to come late to this discussion. The tests should clean up all temporary files and buffers left during their execution. There has been some work on this in the last month or two so hopefully the situation has improved. > =E2=80=94 the trouble is that they leave tangled files and results produc= ed > during suceesful tests. > It will be up to the authors of individual tests to remove tangled and exported files. Ideally we can patch each test to clean up after itself. Perhaps we should provide a test macro which accepts a list of file names and optionally removes them if the test exists successfully. e.g., (org-test-with-cleanup '("exported.html" "tangled.sh" etc...) ...test body...) > >> If you use `make check` to run the test suite, you can easily set TMPDIR >> via the TESTS_ENVIRONMENT Makefile variable (assuming that that variable >> is taken into account when making unique file names). Something like > > Yes, that's about the same conclusion I also reached. Not sure when > I'll have time to implement and test it. > Even if the above is implemented this sounds like a good safeguard. Thanks, > > > Regards, > Achim. --=20 Eric Schulte http://cs.unm.edu/~eschulte/