emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <eric.schulte@gmx.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Temp files from testing are permanent...
Date: Sun, 19 Feb 2012 09:21:46 -0700	[thread overview]
Message-ID: <87sji6g5ee.fsf@gmx.com> (raw)
In-Reply-To: 877gzkc70m.fsf@Rainer.invalid

Achim Gratz <Stromeko@nexgo.de> writes:

> Eric Schulte <eric.schulte@gmx.com> writes:
>> It will be up to the authors of individual tests to remove tangled and
>> exported files.  Ideally we can patch each test to clean up after
>> itself.  Perhaps we should provide a test macro which accepts a list of
>> file names and optionally removes them if the test exists successfully.
>> e.g.,
>>
>> (org-test-with-cleanup '("exported.html" "tangled.sh" etc...)
>>   ...test body...)
>
> Currently those files would have inpredictable names AFAICS, which would
> defeat that purpose.

I should have been more clear.  I'm thinking that this would be a macro
used /within/ unit tests so that testers could specify what files will
be created (test writers should be able to predict the file names
created by their tests) and then the macro will handle cleanup.  Here's
one implementation of such a macro

  (defmacro org-test-with-cleanup (files &rest body)
    "If BODY executes successfully delete FILES and return results of BODY."
    (declare (indent 1))
    `(let ((result (progn ,@body)))
       (mapc (lambda (file) (when (file-exists-p file) (delete-file file))) files)
       result))

> I'm not sure where to do this, but it occurs to me that it would be
> easier if those files only had a unique prefix that didn't change for
> each invocation of the test suite (a timestamp would be OK, so it is
> easier to see which files you're looking at).  If the files always had
> the same name, you would have to make sure that there was no
> collision, either with existing files or results from earlier tests,
> so that would be no good.  If it is easier to always have the same
> names for the files, one could just make the test directory name
> unique.  I think it is useful for debugging to be able to keep a few
> generation of tests around.
>

I do like the idea of a single directory in which all output files may
be collected.  The only potential downside I see for this is that files
will be generated both from within org files in the testing/examples
directory as well as temporary files.

>
>> Even if the above is implemented this sounds like a good safeguard.
>
> Safeguards are in place in my Makefile fork.
>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2012-02-19 16:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 18:31 Temp files from testing are permanent Achim Gratz
2012-02-14 23:12 ` Olaf Meeuwissen
2012-02-15 17:11   ` Achim Gratz
2012-02-15 18:02     ` Brian Wightman
2012-02-15 18:38       ` Achim Gratz
2012-02-16 20:47         ` Achim Gratz
2012-02-16  0:54     ` Olaf Meeuwissen
2012-02-16 18:14       ` Achim Gratz
2012-02-18 17:46         ` Eric Schulte
2012-02-18 18:48           ` Achim Gratz
2012-02-19 16:21             ` Eric Schulte [this message]
2012-02-19 17:03               ` Achim Gratz
2012-02-20  0:11                 ` Olaf Meeuwissen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sji6g5ee.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).