* bug#17416: bug#17416: insecure temp files in ob-screen.el
[not found] <61ljbl1v.fsf@fencepost.gnu.org>
@ 2014-05-07 9:35 ` Eric Schulte
2014-05-08 7:04 ` Glenn Morris
[not found] ` <dda9asvjj2.fsf@fencepost.gnu.org>
0 siblings, 2 replies; 3+ messages in thread
From: Eric Schulte @ 2014-05-07 9:35 UTC (permalink / raw)
To: Glenn Morris; +Cc: 17416
Glenn Morris <rgm@gnu.org> writes:
> Package: emacs,org-mode
> Version: 24.3.90
> Severity: important
> Tags: security
>
> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
> to use predictable temp-file names, which is a security issue. Using
> `make-temp-file', or if the file names really need to be predictable,
> something equivalent to `doc-view-make-safe-dir' (there should really be
> a general utility function for this IMO) to first create a /tmp
> subdirectory would avoid this.
>
I just pushed up a fix for this issue. Thanks,
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#17416: bug#17416: insecure temp files in ob-screen.el
2014-05-07 9:35 ` bug#17416: bug#17416: insecure temp files in ob-screen.el Eric Schulte
@ 2014-05-08 7:04 ` Glenn Morris
[not found] ` <dda9asvjj2.fsf@fencepost.gnu.org>
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2014-05-08 7:04 UTC (permalink / raw)
To: Eric Schulte; +Cc: 17416
Eric Schulte wrote:
>> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
>> to use predictable temp-file names, which is a security issue. Using
>> `make-temp-file', or if the file names really need to be predictable,
>> something equivalent to `doc-view-make-safe-dir' (there should really be
>> a general utility function for this IMO) to first create a /tmp
>> subdirectory would avoid this.
>
> I just pushed up a fix for this issue. Thanks,
If you mean
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7
then's there still org-babel-screen-test.
(These are definitely fixes that need merging into the emacs-24 branch.
IIUC this means they need to be in your maint branch?)
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#17416: bug#17416: insecure temp files in ob-screen.el
[not found] ` <dda9asvjj2.fsf@fencepost.gnu.org>
@ 2014-05-08 18:20 ` Eric Schulte
0 siblings, 0 replies; 3+ messages in thread
From: Eric Schulte @ 2014-05-08 18:20 UTC (permalink / raw)
To: Glenn Morris; +Cc: 17416, Eric Schulte
Glenn Morris <rgm@gnu.org> writes:
> Eric Schulte wrote:
>
>>> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
>>> to use predictable temp-file names, which is a security issue. Using
>>> `make-temp-file', or if the file names really need to be predictable,
>>> something equivalent to `doc-view-make-safe-dir' (there should really be
>>> a general utility function for this IMO) to first create a /tmp
>>> subdirectory would avoid this.
>>
>> I just pushed up a fix for this issue. Thanks,
>
> If you mean
>
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7
>
> then's there still org-babel-screen-test.
>
Fixed.
>
> (These are definitely fixes that need merging into the emacs-24 branch.
> IIUC this means they need to be in your maint branch?)
Cherrypicked into maint.
Thanks,
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-08 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <61ljbl1v.fsf@fencepost.gnu.org>
2014-05-07 9:35 ` bug#17416: bug#17416: insecure temp files in ob-screen.el Eric Schulte
2014-05-08 7:04 ` Glenn Morris
[not found] ` <dda9asvjj2.fsf@fencepost.gnu.org>
2014-05-08 18:20 ` Eric Schulte
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).