From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: bug#17416:  bug#17416: insecure temp files in ob-screen.el
Date: Thu, 08 May 2014 12:20:23 -0600
Message-ID: <87a9asku8o.fsf__43604.6604453169$1399573313$gmane$org@gmail.com>
References: <61ljbl1v.fsf@fencepost.gnu.org> <87vbthm5pe.fsf@gmail.com>
	<dda9asvjj2.fsf@fencepost.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WiSwN-0001Wh-Jf
	for emacs-orgmode@gnu.org; Thu, 08 May 2014 14:21:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WiSwI-00058i-Ns
	for emacs-orgmode@gnu.org; Thu, 08 May 2014 14:21:07 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.17416.B17416.139957325918597@debbugs.gnu.org>
In-Reply-To: <dda9asvjj2.fsf@fencepost.gnu.org> (Glenn Morris's message of
	"Thu, 08 May 2014 03:04:01 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Glenn Morris <rgm@gnu.org>
Cc: 17416@debbugs.gnu.org, Eric Schulte <schulte.eric@gmail.com>

Glenn Morris <rgm@gnu.org> writes:

> Eric Schulte wrote:
>
>>> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
>>> to use predictable temp-file names, which is a security issue. Using
>>> `make-temp-file', or if the file names really need to be predictable,
>>> something equivalent to `doc-view-make-safe-dir' (there should really be
>>> a general utility function for this IMO) to first create a /tmp
>>> subdirectory would avoid this.
>>
>> I just pushed up a fix for this issue.  Thanks,
>
> If you mean
>
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7
>
> then's there still org-babel-screen-test.
>

Fixed.

>
> (These are definitely fixes that need merging into the emacs-24 branch.
> IIUC this means they need to be in your maint branch?)

Cherrypicked into maint.

Thanks,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D