From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption for minted listings
Date: Sun, 24 Aug 2014 01:56:41 +0200 [thread overview]
Message-ID: <87a96uep52.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87oavbostg.fsf@gmail.com> (Aaron Ecay's message of "Sat, 23 Aug 2014 16:27:07 -0400")
Aaron Ecay <aaronecay@gmail.com> writes:
> It’s not adding any new functionality to the exporter,
Well, it is, since "captionof" command doesn't exist in Org default
packages.
> but rather covering one particular combination of already-existing
> options (caption provided, :float nil, org-latex-listings = minted)
> that does not produce sensible output presently. Should I fix the
> nil/no issue and send a new patch?
With your patch, when encountering the combination above, the export
back-end will introduce a "captionof" command, which requires loading
"caption" package with a specific option (i.e., compatibility=false).
If this is explained nowhere, it is hardly a fix. If you document it,
you introduce support for "caption" package in Org. Is there a strong
reason for that?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-08-23 23:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 7:36 [RFC] [PATCH] ox-latex: support :float no with caption for minted listings Aaron Ecay
2014-08-23 19:47 ` Nicolas Goaziou
2014-08-23 20:27 ` Aaron Ecay
2014-08-23 23:56 ` Nicolas Goaziou [this message]
2014-08-24 0:44 ` Aaron Ecay
2014-08-24 6:51 ` Nicolas Richard
2014-08-24 19:54 ` Nicolas Goaziou
2014-08-28 5:03 ` Aaron Ecay
2014-08-28 9:19 ` Nicolas Goaziou
2014-09-19 19:04 ` Aaron Ecay
2014-09-19 20:13 ` Nicolas Goaziou
2014-09-23 3:09 ` Aaron Ecay
2014-09-23 19:48 ` Nicolas Goaziou
2014-09-28 4:07 ` Aaron Ecay
2014-09-28 7:09 ` Nicolas Goaziou
2014-09-28 12:00 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a96uep52.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).