From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption for minted listings Date: Sun, 24 Aug 2014 01:56:41 +0200 Message-ID: <87a96uep52.fsf@nicolasgoaziou.fr> References: <1408779394-11436-1-git-send-email-aaronecay@gmail.com> <87ha13dm3v.fsf@nicolasgoaziou.fr> <87oavbostg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLLAE-0003cC-G4 for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 19:56:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLLA4-0003am-CF for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 19:56:06 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:51154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLLA4-0003ag-5Y for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 19:55:56 -0400 Received: from mfilter4-d.gandi.net (mfilter4-d.gandi.net [217.70.178.134]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 09426A8092 for ; Sun, 24 Aug 2014 01:55:55 +0200 (CEST) Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter4-d.gandi.net (mfilter4-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id TbUgnl1xnM9O for ; Sun, 24 Aug 2014 01:55:53 +0200 (CEST) Received: from selenimh (unknown [91.224.148.150]) (Authenticated sender: mail@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A0B53A80AF for ; Sun, 24 Aug 2014 01:55:53 +0200 (CEST) In-Reply-To: <87oavbostg.fsf@gmail.com> (Aaron Ecay's message of "Sat, 23 Aug 2014 16:27:07 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > It=E2=80=99s not adding any new functionality to the exporter, Well, it is, since "captionof" command doesn't exist in Org default packages. > but rather covering one particular combination of already-existing > options (caption provided, :float nil, org-latex-listings =3D minted) > that does not produce sensible output presently. Should I fix the > nil/no issue and send a new patch? With your patch, when encountering the combination above, the export back-end will introduce a "captionof" command, which requires loading "caption" package with a specific option (i.e., compatibility=3Dfalse). If this is explained nowhere, it is hardly a fix. If you document it, you introduce support for "caption" package in Org. Is there a strong reason for that? Regards, --=20 Nicolas Goaziou