emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Aaron Ecay <aaronecay@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>, emacs-orgmode@gnu.org
Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption for minted listings
Date: Sat, 23 Aug 2014 20:44:36 -0400	[thread overview]
Message-ID: <87d2bqpvgr.fsf@gmail.com> (raw)
In-Reply-To: <87a96uep52.fsf@nicolasgoaziou.fr>

Hi Nicolas,

2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen:
> 
> Aaron Ecay <aaronecay@gmail.com> writes:
> 
>> It’s not adding any new functionality to the exporter,
> 
> Well, it is, since "captionof" command doesn't exist in Org default
> packages.

I guess this was unclear.  What I meant was that the patch is not
introducing any new expressivity on the org-mode side.  There is a
situation (described in my previous mail) that is a valid combination of
org configuration variables and buffer text, which produces inconsistent
latex output.  This patch fixes that.

> 
>> but rather covering one particular combination of already-existing
>> options (caption provided, :float nil, org-latex-listings = minted)
>> that does not produce sensible output presently. Should I fix the
>> nil/no issue and send a new patch?
> 
> With your patch, when encountering the combination above, the export
> back-end will introduce a "captionof" command, which requires loading
> "caption" package with a specific option (i.e., compatibility=false).

Why is the compatibility=false option needed?  I can’t figure this
out.

> 
> If this is explained nowhere, it is hardly a fix. If you document it,
> you introduce support for "caption" package in Org. Is there a strong
> reason for that?

“Pretty” source code export in all cases requires adding certain packages
to the default, as explained in the docstring of ‘org-latex-listings’.
The patch adds discussion of the caption requirement there, so there is
no “if” about the documentation.

I don’t understand what you’re saying about introducing “support” for
the caption package.  The patch uses one specific feature of the caption
package in one specific place to accomplish one specific goal.  There
are no other changes needed anywhere else in the codebase than these
couple of lines in one function (plus the documentation).

The motivating reason is described in my first paragraph above – making
the output consistent for all combinations of options.

Thanks,

-- 
Aaron Ecay

next prev parent reply	other threads:[~2014-08-24  0:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23  7:36 [RFC] [PATCH] ox-latex: support :float no with caption for minted listings Aaron Ecay
2014-08-23 19:47 ` Nicolas Goaziou
2014-08-23 20:27   ` Aaron Ecay
2014-08-23 23:56     ` Nicolas Goaziou
2014-08-24  0:44       ` Aaron Ecay [this message]
2014-08-24  6:51         ` Nicolas Richard
2014-08-24 19:54         ` Nicolas Goaziou
2014-08-28  5:03           ` Aaron Ecay
2014-08-28  9:19             ` Nicolas Goaziou
2014-09-19 19:04               ` Aaron Ecay
2014-09-19 20:13                 ` Nicolas Goaziou
2014-09-23  3:09                   ` Aaron Ecay
2014-09-23 19:48                     ` Nicolas Goaziou
2014-09-28  4:07                       ` Aaron Ecay
2014-09-28  7:09                         ` Nicolas Goaziou
2014-09-28 12:00                         ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2bqpvgr.fsf@gmail.com \
    --to=aaronecay@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).