* [bug, org-table] new hline doesn't update formula
@ 2015-05-15 17:34 Rasmus
2015-05-17 19:00 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Rasmus @ 2015-05-15 17:34 UTC (permalink / raw)
To: emacs-orgmode
Hi,
Consider this example:
|---+---+---|
| a | b | c |
| d | e | f |
|---+---+---|
| 1 | 2 | 3 |
| 4 | 5 | 6 |
|---+---+---|
| 5 | 7 | 9 |
#+TBLFM: @5=vsum(@II..@III)
Insert a hline after |a|b|c|. The formula is now broken.
Expected behavior: org-table-insert-hline should call
org-table-fix-formulas, though this does not currently support hlines, it
seems.
I have no idea how trivial or hard this is to fix this... But hints or
fixes are appreciated.
—Rasmus
--
The Kids call him Billy the Saint
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [bug, org-table] new hline doesn't update formula
2015-05-15 17:34 [bug, org-table] new hline doesn't update formula Rasmus
@ 2015-05-17 19:00 ` Nicolas Goaziou
2015-05-17 19:06 ` Rasmus
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2015-05-17 19:00 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode
Hello,
Rasmus <rasmus@gmx.us> writes:
> Consider this example:
>
> |---+---+---|
> | a | b | c |
> | d | e | f |
> |---+---+---|
> | 1 | 2 | 3 |
> | 4 | 5 | 6 |
> |---+---+---|
> | 5 | 7 | 9 |
> #+TBLFM: @5=vsum(@II..@III)
>
> Insert a hline after |a|b|c|. The formula is now broken.
What should happen to the formula if hline is inserted between |1|2|3|
and |4|5|6|?
> Expected behavior: org-table-insert-hline should call
> org-table-fix-formulas, though this does not currently support hlines, it
> seems.
>
> I have no idea how trivial or hard this is to fix this... But hints or
> fixes are appreciated.
It doesn't seem too hard to fix. I think we just need to extend
`org-table-fix-formulas' to handle "@I" parts and call it from
`org-table-insert-hline'.
Anyway, actual fix depends on the answer to my initial question.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [bug, org-table] new hline doesn't update formula
2015-05-17 19:00 ` Nicolas Goaziou
@ 2015-05-17 19:06 ` Rasmus
2015-05-18 7:34 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Rasmus @ 2015-05-17 19:06 UTC (permalink / raw)
To: emacs-orgmode
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Rasmus <rasmus@gmx.us> writes:
>
>> Consider this example:
>>
>> |---+---+---|
>> | a | b | c |
>> | d | e | f |
>> |---+---+---|
>> | 1 | 2 | 3 |
>> | 4 | 5 | 6 |
>> |---+---+---|
>> | 5 | 7 | 9 |
>> #+TBLFM: @5=vsum(@II..@III)
>>
>> Insert a hline after |a|b|c|. The formula is now broken.
>
> What should happen to the formula if hline is inserted between |1|2|3|
> and |4|5|6|?
Good question. I'm not sure. While not necessarily the most obvious I
think in that case the formula should be unchanged. But it's not obvious.
>> Expected behavior: org-table-insert-hline should call
>> org-table-fix-formulas, though this does not currently support hlines, it
>> seems.
>>
>> I have no idea how trivial or hard this is to fix this... But hints or
>> fixes are appreciated.
>
> It doesn't seem too hard to fix. I think we just need to extend
> `org-table-fix-formulas' to handle "@I" parts and call it from
> `org-table-insert-hline'.
I guess something like that.
> Anyway, actual fix depends on the answer to my initial question.
Yeah...
—Rasmus
--
. . . The proofs are technical in nature and provides no real understanding
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [bug, org-table] new hline doesn't update formula
2015-05-17 19:06 ` Rasmus
@ 2015-05-18 7:34 ` Nicolas Goaziou
2015-05-18 9:51 ` Rasmus
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2015-05-18 7:34 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode
Rasmus <rasmus@gmx.us> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>> Consider this example:
>>>
>>> |---+---+---|
>>> | a | b | c |
>>> | d | e | f |
>>> |---+---+---|
>>> | 1 | 2 | 3 |
>>> | 4 | 5 | 6 |
>>> |---+---+---|
>>> | 5 | 7 | 9 |
>>> #+TBLFM: @5=vsum(@II..@III)
[...]
>> What should happen to the formula if hline is inserted between |1|2|3|
>> and |4|5|6|?
>
> Good question. I'm not sure. While not necessarily the most obvious I
> think in that case the formula should be unchanged. But it's not
> obvious.
Another tricky example
| 1 |
|----|
| 2 |
| 3 |
| 4 |
|----|
| 5 |
|----|
| 14 |
#+TBLFM: @6=vsum(@I..@III)
What if we insert a hline between |3| and |4|?
I assume it should become "@I..@IIII". Yet, the difference between it
and the case before is subtle, and hard to explain.
That leads me to the next question: should we really mess with this?
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-18 17:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 17:34 [bug, org-table] new hline doesn't update formula Rasmus
2015-05-17 19:00 ` Nicolas Goaziou
2015-05-17 19:06 ` Rasmus
2015-05-18 7:34 ` Nicolas Goaziou
2015-05-18 9:51 ` Rasmus
2015-05-18 17:31 ` Achim Gratz
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).